qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64
@ 2011-02-08 17:39 Christophe Lyon
  2011-02-09 13:55 ` Peter Maydell
  0 siblings, 1 reply; 3+ messages in thread
From: Christophe Lyon @ 2011-02-08 17:39 UTC (permalink / raw)
  To: qemu-devel@nongnu.org


Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
---
Submitted as a standalone patch as suggested by Peter, along with his corrections.

 target-arm/translate.c |   14 +++++++++++++-
 1 files changed, 13 insertions(+), 1 deletions(-)

diff --git a/target-arm/translate.c b/target-arm/translate.c
index e4649e6..b694eed 100644
--- a/target-arm/translate.c
+++ b/target-arm/translate.c
@@ -4688,7 +4688,19 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn)
                             tcg_gen_add_i64(cpu_V0, cpu_V0, cpu_V1);
                         } else if (op == 4 || (op == 5 && u)) {
                             /* Insert */
-                            cpu_abort(env, "VS[LR]I.64 not implemented");
+                            neon_load_reg64(cpu_V1, rd + pass);
+                            uint64_t mask;
+                            if (shift < -63 || shift > 63) {
+                                mask = 0;
+                            } else {
+                                if (op == 4) {
+                                    mask = 0xffffffffffffffffull >> -shift;
+                                } else {
+                                    mask = 0xffffffffffffffffull << shift;
+                                }
+                            }
+                            tcg_gen_andi_i64(cpu_V1, cpu_V1, ~mask);
+                            tcg_gen_or_i64(cpu_V0, cpu_V0, cpu_V1);
                         }
                         neon_store_reg64(cpu_V0, rd + pass);
                     } else { /* size < 3 */
-- 
1.7.2.3

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64
  2011-02-08 17:39 [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64 Christophe Lyon
@ 2011-02-09 13:55 ` Peter Maydell
  2011-02-09 18:49   ` Aurelien Jarno
  0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2011-02-09 13:55 UTC (permalink / raw)
  To: Christophe Lyon; +Cc: qemu-devel@nongnu.org

On 8 February 2011 17:39, Christophe Lyon <christophe.lyon@st.com> wrote:
>
> Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
> ---
> Submitted as a standalone patch as suggested by Peter, along with his corrections.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

-- PMM

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64
  2011-02-09 13:55 ` Peter Maydell
@ 2011-02-09 18:49   ` Aurelien Jarno
  0 siblings, 0 replies; 3+ messages in thread
From: Aurelien Jarno @ 2011-02-09 18:49 UTC (permalink / raw)
  To: Peter Maydell; +Cc: Christophe Lyon, qemu-devel@nongnu.org

On Wed, Feb 09, 2011 at 01:55:46PM +0000, Peter Maydell wrote:
> On 8 February 2011 17:39, Christophe Lyon <christophe.lyon@st.com> wrote:
> >
> > Signed-off-by: Christophe Lyon <christophe.lyon@st.com>
> > ---
> > Submitted as a standalone patch as suggested by Peter, along with his corrections.
> 
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> 

Thanks, applied.

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-02-09 18:49 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-08 17:39 [Qemu-devel] [PATCH v2] target-arm: implement vsli.64, vsri.64 Christophe Lyon
2011-02-09 13:55 ` Peter Maydell
2011-02-09 18:49   ` Aurelien Jarno

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).