From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49153 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pmu70-0000E4-5C
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 15:24:35 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Pmu6y-0001iu-KZ
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 15:24:34 -0500
Received: from fmmailgate01.web.de ([217.72.192.221]:59614)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1Pmu6y-0001iZ-Bh
	for qemu-devel@nongnu.org; Tue, 08 Feb 2011 15:24:32 -0500
Message-ID: <4D51A67A.7080306@web.de>
Date: Tue, 08 Feb 2011 21:24:26 +0100
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <1297185509-20996-1-git-send-email-pbonzini@redhat.com>
	<1297185509-20996-7-git-send-email-pbonzini@redhat.com>
In-Reply-To: <1297185509-20996-7-git-send-email-pbonzini@redhat.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig8190DE3D8DBD691E252D8D16"
Sender: jan.kiszka@web.de
Subject: [Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if
 cpu->stopped is true
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig8190DE3D8DBD691E252D8D16
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

On 2011-02-08 18:18, Paolo Bonzini wrote:
> Sometimes vcpus are stopped directly without going through ->stop =3D 1=
=2E
> Exit the VCPU execution loop in this case as well.
>=20
> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
> ---
>  cpus.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>=20
> diff --git a/cpus.c b/cpus.c
> index c1d0ceb..5b13961 100644
> --- a/cpus.c
> +++ b/cpus.c
> @@ -1061,7 +1061,7 @@ bool cpu_exec_all(void)
>              if (r =3D=3D EXCP_DEBUG) {
>                  break;
>              }
> -        } else if (env->stop) {
> +        } else if (env->stop || env->stopped) {
>              break;
>          }
>      }

Hmm, does this path actually trigger? If yes, does it happen to obsolete
the global exit_request hack?

Jan


--------------enig8190DE3D8DBD691E252D8D16
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.15 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/

iEYEARECAAYFAk1Rpn4ACgkQitSsb3rl5xSK3QCgp6PLkiPWtLbDcIw5i64ZnbCN
WsYAoL/OwkBYNboQtxWgRWHXckxBxYlu
=UyBX
-----END PGP SIGNATURE-----

--------------enig8190DE3D8DBD691E252D8D16--