From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39670 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pn3os-0007Wc-0V
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 01:46:30 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1Pn3op-0003xb-N7
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 01:46:29 -0500
Received: from [222.73.24.84] (port=58250 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <laijs@cn.fujitsu.com>) id 1Pn3op-0003wd-7s
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 01:46:27 -0500
Message-ID: <4D523848.5030400@cn.fujitsu.com>
Date: Wed, 09 Feb 2011 14:46:32 +0800
From: Lai Jiangshan <laijs@cn.fujitsu.com>
MIME-Version: 1.0
References: <4D412ACB.3050101@cn.fujitsu.com> <20110201112915.56395b0a@doriath>
In-Reply-To: <20110201112915.56395b0a@doriath>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=UTF-8
Subject: [Qemu-devel] Re: [PATCH V6 1/4] nmi: convert cpu_index to cpu-index
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, Lai Jiangshan <eag0628@gmail.com>, kvm@vger.kernel.org, Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

On 02/01/2011 09:29 PM, Luiz Capitulino wrote:
> On Thu, 27 Jan 2011 16:20:27 +0800
> Lai Jiangshan <laijs@cn.fujitsu.com> wrote:
> 
>> "cpu-index" which uses hyphen is better name.
>>
>> Signed-off-by:  Lai Jiangshan <laijs@cn.fujitsu.com>
> 
> It looks ok from a quick pass, but I can't apply it on current master, what
> commit HEAD did you?

It is origin for this HEAD:

commit 6f32e3d09d990fd50008756fcb446b55e0c0af79
Merge: f447f8c 0f46d15
Author: Marcelo Tosatti <mtosatti@redhat.com>
Date:   Fri Jan 21 20:34:47 2011 -0200

    Merge branch 'upstream-merge'

It can be also applied on the today's master.
The tree I used is:
http://git.kernel.org/pub/scm/virt/kvm/qemu-kvm.git

Thank you very much.
Lai.

> 
> Btw, please, do include the patch 0/0 with a general description about the
> series and a small changelog between changes.
> 
>> ---
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index 5d4cb9e..e43ac7c 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -721,7 +721,7 @@ ETEXI
>>  #if defined(TARGET_I386)
>>      {
>>          .name       = "nmi",
>> -        .args_type  = "cpu_index:i",
>> +        .args_type  = "cpu-index:i",
>>          .params     = "cpu",
>>          .help       = "inject an NMI on the given CPU",
>>          .mhandler.cmd = do_inject_nmi,
>> diff --git a/monitor.c b/monitor.c
>> index 27883f8..a916771 100644
>> --- a/monitor.c
>> +++ b/monitor.c
>> @@ -2545,7 +2545,7 @@ static void do_wav_capture(Monitor *mon, const QDict *qdict)
>>  static void do_inject_nmi(Monitor *mon, const QDict *qdict)
>>  {
>>      CPUState *env;
>> -    int cpu_index = qdict_get_int(qdict, "cpu_index");
>> +    int cpu_index = qdict_get_int(qdict, "cpu-index");
>>  
>>      for (env = first_cpu; env != NULL; env = env->next_cpu)
>>          if (env->cpu_index == cpu_index) {
>>
> 
>