From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46698 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pn4Pr-0007cl-4T
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 02:24:43 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pn4Pp-0001jH-Gn
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 02:24:42 -0500
Received: from mail-ww0-f53.google.com ([74.125.82.53]:37389)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pn4Pp-0001iq-BW
	for qemu-devel@nongnu.org; Wed, 09 Feb 2011 02:24:41 -0500
Received: by wwi18 with SMTP id 18so6479984wwi.10
	for <qemu-devel@nongnu.org>; Tue, 08 Feb 2011 23:24:40 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D524134.8040504@redhat.com>
Date: Wed, 09 Feb 2011 08:24:36 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1297185509-20996-1-git-send-email-pbonzini@redhat.com>	<1297185509-20996-7-git-send-email-pbonzini@redhat.com>
	<4D51A67A.7080306@web.de>
In-Reply-To: <4D51A67A.7080306@web.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [CFT PATCH 06/12] exit round-robin vcpu loop if
 cpu->stopped is true
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org

On 02/08/2011 09:24 PM, Jan Kiszka wrote:
> Hmm, does this path actually trigger? If yes, does it happen to obsolete
> the global exit_request hack?

No idea, I wanted to make the initial work as mechanical as possible. 
By inspection, cpu_stop_current is doing

          cpu_single_env->stopped = 1;
          cpu_exit(cpu_single_env);

without setting ->stop.  (I'm changing that in patch 7, but I'm setting 
->stop to 0, not 1).

Paolo