From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37338 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pn89C-00054p-6h for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:23:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pn89A-0008Fc-SU for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:23:45 -0500 Received: from mx1.redhat.com ([209.132.183.28]:24001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pn89A-0008FV-I7 for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:23:44 -0500 Message-ID: <4D52793B.6010104@redhat.com> Date: Wed, 09 Feb 2011 13:23:39 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v4 2/3] qcow2: Use QcowCache References: <1295543412-24012-1-git-send-email-kwolf@redhat.com> <1295543412-24012-3-git-send-email-kwolf@redhat.com> <4D527847.9070400@redhat.com> In-Reply-To: <4D527847.9070400@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: stefanha@gmail.com, qemu-devel@nongnu.org On 02/09/2011 01:19 PM, Avi Kivity wrote: > On 01/20/2011 07:10 PM, Kevin Wolf wrote: >> Use the new functions of qcow2-cache.c for everything that works on >> refcount >> block and L2 tables. >> > > While autotesting qemu-kvm's stable-0.14 branch, this commit causes > failures. The scenario is: > > - install OS > - reboot > - hang at GRUB prompt > - qemu-img reports hundreds of leaked clusters > > The actual commit I am testing is in qemu-kvm.git > qcow2-qcowcache-failure (tag). The test runs with -drive ,cache=unsafe. Got it - it's specific to qemu-kvm; the call to bdrv_close_all() wasn't replicated in qemu-kvm's main loop. -- error compiling committee.c: too many arguments to function