From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=48135 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pn8D2-00084N-Vh for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:27:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pn8D0-0000ws-0H for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:27:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:13229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pn8Cz-0000wb-Oe for qemu-devel@nongnu.org; Wed, 09 Feb 2011 06:27:41 -0500 Message-ID: <4D527A95.4040608@redhat.com> Date: Wed, 09 Feb 2011 12:29:25 +0100 From: Kevin Wolf MIME-Version: 1.0 References: <1297247521-11464-1-git-send-email-kwolf@redhat.com> <1297247521-11464-4-git-send-email-kwolf@redhat.com> <4D5278B3.3040604@codemonkey.ws> In-Reply-To: <4D5278B3.3040604@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 3/4] qed: Report error for unsupported features List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: stefanha@gmail.com, qemu-devel@nongnu.org, lcapitulino@redhat.com Am 09.02.2011 12:21, schrieb Anthony Liguori: > On 02/09/2011 04:32 AM, Kevin Wolf wrote: >> Instead of just returning -ENOTSUP, generate a more detailed error. >> >> Unfortunately we don't have a helpful text for features that we don't know yet, >> so just print the feature mask. It might be useful at least if someone asks for >> help. >> >> Signed-off-by: Kevin Wolf >> > > We can use a compatible feature to create a feature name table. If you want to introduce something like this in a 0.14-rc2...? I'm not going to write the code, but if someone sends a patch, we can consider it. >> --- >> block/qed.c | 8 +++++++- >> 1 files changed, 7 insertions(+), 1 deletions(-) >> >> diff --git a/block/qed.c b/block/qed.c >> index 3273448..8b0a975 100644 >> --- a/block/qed.c >> +++ b/block/qed.c >> @@ -14,6 +14,7 @@ >> >> #include "trace.h" >> #include "qed.h" >> +#include "qerror.h" >> >> static void qed_aio_cancel(BlockDriverAIOCB *blockacb) >> { >> @@ -311,7 +312,12 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags) >> return -EINVAL; >> } >> if (s->header.features& ~QED_FEATURE_MASK) { >> - return -ENOTSUP; /* image uses unsupported feature bits */ >> + /* image uses unsupported feature bits */ >> + char version[64]; >> + snprintf(version, sizeof(version), "%" PRIx64, s->header.features); >> > > It would be useful to do s->header.features & QED_FEATURE_MASK here as a > management tool doesn't know what features this version of QED supports. Makes sense. I'll change this for v2. Kevin