* [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation
[not found] <4560.09833510524$1294992458@news.gmane.org>
@ 2011-02-10 9:51 ` Paolo Bonzini
2011-02-10 9:54 ` Pavel Dovgaluk
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2011-02-10 9:51 UTC (permalink / raw)
To: Pavel Dovgaluk; +Cc: qemu-devel
> diff --git a/Makefile.objs b/Makefile.objs
> index 4a1eaa1..ee9f190 100755
> --- a/Makefile.objs
> +++ b/Makefile.objs
> @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS)
> vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS)
> -vl.o: qemu-options.def
> +vl.o: ../qemu-options.def
> os-posix.o: qemu-options.def
> os-win32.o: qemu-options.def
> -qemu-options.def: $(SRC_PATH)/qemu-options.hx
> +%qemu-options.def: $(SRC_PATH)/qemu-options.hx
> $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN $(TARGET_DIR)$@")
This is wrong, I think the problem is that you are missing a vpath
directive.
Does this help?
diff --git a/rules.mak b/rules.mak
index ed59c9e..6f753ae 100644
--- a/rules.mak
+++ b/rules.mak
@@ -39,7 +39,7 @@ quiet-command = $(if $(V),$1,$(if $(2),@echo $2 && $1, @$1))
cc-option = $(if $(shell $(CC) $1 $2 -S -o /dev/null -xc /dev/null \
>/dev/null 2>&1 && echo OK), $2, $3)
-VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi
+VPATH_SUFFIXES = %.c %.h %.S %.m %.mak %.texi %.def
set-vpath = $(if $1,$(foreach PATTERN,$(VPATH_SUFFIXES),$(eval vpath $(PATTERN) $1)))
# find-in-path
Paolo
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation
2011-02-10 9:51 ` [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation Paolo Bonzini
@ 2011-02-10 9:54 ` Pavel Dovgaluk
0 siblings, 0 replies; 2+ messages in thread
From: Pavel Dovgaluk @ 2011-02-10 9:54 UTC (permalink / raw)
To: 'Paolo Bonzini'; +Cc: qemu-devel
> > diff --git a/Makefile.objs b/Makefile.objs
> > index 4a1eaa1..ee9f190 100755
> > --- a/Makefile.objs
> > +++ b/Makefile.objs
> > @@ -269,10 +269,10 @@ vl.o: QEMU_CFLAGS+=$(GPROF_CFLAGS)
> > vl.o: QEMU_CFLAGS+=$(SDL_CFLAGS)
> > -vl.o: qemu-options.def
> > +vl.o: ../qemu-options.def
> > os-posix.o: qemu-options.def
> > os-win32.o: qemu-options.def
> > -qemu-options.def: $(SRC_PATH)/qemu-options.hx
> > +%qemu-options.def: $(SRC_PATH)/qemu-options.hx
> > $(call quiet-command,sh $(SRC_PATH)/hxtool -h < $< > $@," GEN
> $(TARGET_DIR)$@")
>
> This is wrong, I think the problem is that you are missing a vpath
> directive.
>
> Does this help?
This patch was for older version of qemu.
Current one does not have this problem.
Pavel Dovgaluk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-10 9:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <4560.09833510524$1294992458@news.gmane.org>
2011-02-10 9:51 ` [Qemu-devel] Re: [PATCH] Fix multiple qemu-options.def generation Paolo Bonzini
2011-02-10 9:54 ` Pavel Dovgaluk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).