From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51380 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pns7F-00008d-N9
	for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:28:51 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pns7B-0004Dc-4Y
	for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:28:46 -0500
Received: from mx1.redhat.com ([209.132.183.28]:63815)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pns7A-0004DQ-Ng
	for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:28:44 -0500
Message-ID: <4D552B67.9050107@redhat.com>
Date: Fri, 11 Feb 2011 13:28:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1297359464-9789-1-git-send-email-pbonzini@redhat.com>
	<1297359464-9789-5-git-send-email-pbonzini@redhat.com>
	<4D544085.2030206@mail.berlios.de>
In-Reply-To: <4D544085.2030206@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/7] add win32 qemu-thread implementation
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel@nongnu.org

On 02/10/2011 08:46 PM, Stefan Weil wrote:
> Am 10.02.2011 18:37, schrieb Paolo Bonzini:
>> For now, qemu_cond_timedwait and qemu_mutex_timedlock are left as
>> POSIX-only functions. They can be removed later, once the patches
>> that remove their uses are in.
>>
>> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>> Cc: Stefan Weil <weil@mail.berlios.de>
>> Cc: Blue Swirl <blauwirbel@gmail.com>
>> ---
>> Makefile.objs | 4 +-
>> qemu-thread.c => qemu-thread-posix.c | 0
>> qemu-thread-posix.h | 18 +++
>> qemu-thread-win32.c | 272 ++++++++++++++++++++++++++++++++++
>> qemu-thread-win32.h | 22 +++
>> qemu-thread.h | 27 ++--
>> 6 files changed, 326 insertions(+), 17 deletions(-)
>> rename qemu-thread.c => qemu-thread-posix.c (100%)
>> create mode 100644 qemu-thread-posix.h
>> create mode 100644 qemu-thread-win32.c
>> create mode 100644 qemu-thread-win32.h
>>
>
> What about using MinGW's pthread support?
> http://sourceforge.net/projects/mingw/files/MinGW/pthreads-w32/
>
> I used it for the threaded vnc server in QEMU, but I don't
> have more practical experience with it.

1) For threads, we'd need to do the same in order to keep the HANDLE for 
iothread IPIs (SuspendThread/ResumeThread).  We could use nonportable 
functions from pthread-w32, but if for example in the future QEMU 
switched to glib these wouldn't be available.  So QEMU would need a 
separate Win32 implementation anyway sooner or later.

2) For condvars, we can make some more assumptions and make it 
simpler/faster.

3) It has some namespace pollution issues.  These wouldn't be a problem 
for QEMU at the moment, however.

Paolo