From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41430 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnsVp-0006sw-Pk for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:54:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnsVo-0000yO-RK for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:54:13 -0500 Received: from thoth.sbs.de ([192.35.17.2]:27997) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnsVo-0000y8-Hx for qemu-devel@nongnu.org; Fri, 11 Feb 2011 07:54:12 -0500 Message-ID: <4D55316E.4020408@siemens.com> Date: Fri, 11 Feb 2011 13:54:06 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1297359464-9789-1-git-send-email-pbonzini@redhat.com> <1297359464-9789-7-git-send-email-pbonzini@redhat.com> <4D542D88.10000@siemens.com> <4D55283E.2030405@redhat.com> In-Reply-To: <4D55283E.2030405@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 6/7] add assertions on the owner of a QemuMutex List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Blue Swirl , "qemu-devel@nongnu.org" On 2011-02-11 13:14, Paolo Bonzini wrote: > On 02/10/2011 07:25 PM, Jan Kiszka wrote: >> On 2011-02-10 18:37, Paolo Bonzini wrote: >>> These are already present in the Win32 implementation, add them to >>> the pthread wrappers as well. >> >> Better use PTHREAD_MUTEX_ERRORCHECK. > > True. However, later I'd like to include tests that the mutex is held > during cond_signal/cond_broadcast, so I would have to track the owner > manually anyway. You could still save the assertions where pthread does the work already. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux