From: Anthony Liguori <anthony@codemonkey.ws>
To: Avi Kivity <avi@redhat.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Chris Wright <chrisw@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
kvm@vger.kernel.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] KVM call minutes for Feb 8
Date: Sun, 13 Feb 2011 10:56:30 -0600 [thread overview]
Message-ID: <4D580D3E.3000300@codemonkey.ws> (raw)
In-Reply-To: <4D57FF2E.7020001@redhat.com>
On 02/13/2011 09:56 AM, Avi Kivity wrote:
> On 02/13/2011 05:38 PM, Anthony Liguori wrote:
>>>
>>>>
>>>> 2) get rid of the entire concept of machines. Creating a i440fx is
>>>> essentially equivalent to creating a bare machine.
>>>
>>> No, it's not. The 440fx does not include an IOAPIC, for example.
>>> There may be other optional components, or differences in wiring,
>>> that make two machines with i440fx not identical.
>>
>>
>> The IOAPIC is basically the only other component and I view it as
>> part of the CPU interface to the chipset.
>
> But it isn't. The IOAPIC is not per-core or per-socket.
Yeah, I wasn't implying that it was.
> It's strictly board level. It's a board interface to the cpu.
>
>>
>> But still, if we're creating a machine from scratch:
>>
>> qemu -device i440fx,id=nb -device piix3,id=sb,chipset=nb -device
>> ioapic,id=ioapic,chipset=sb -device cpu,ioapic=ioapic,northbridge=nb
>>
>> Is not all that unreasonable and presents a fully functioning PC.
>
> Sure. And -M blah is a shortcut.
Exactly. Or better yet, blah is a config file that contains
[device "nb"]
driver=i440fx
[device "sb"]
driver=piix3
chipset=nb
[device "ioapic"]
driver=ioapic
chipset=sb
[device "cpu"]
driver=cpu
ioapic=ioapic
northbridge=nb
>>
>>>>
>>>> 4) model the CPUs as devices that take a pointer to a host
>>>> controller, for x86, the normal case would be giving it a pointer
>>>> to i440fx.
>>>>
>>>
>>> Surely the connection is via a bus? An x86 cpu talks to the bus,
>>> and there happens to be an 440fx north bridge at the end of it. It
>>> could also be a Q35 or something else.
>>
>> I see being on a bus as really just taking a pointer to an
>> interface. So yes, the i440fx would implement a PentiumCpuInterface
>> or something like that and the CPU would take a pointer to a
>> PentiumCpuInterface[1].
>>
>> This is part of why having proper polymorphism is important. We need
>> it in order to be able to express concepts like interfaces.
>
> The CPUs and northbridge are peers on the system bus. However, this
> isn't something good to model, since it keeps changing without any
> guest software impact.
If we can move away from Bus abstraction and to a simpler interface
mechanism, then we can express peer relationships by just having
bidirection references. IOW:
-device cpus,northbridge=nb,id=cpus,count=16 -device i440fx,cpus=cpus
I don't think modelling each CPU makes sense. We should probably just
model all cpus in a single device for the sake of simplicity.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2011-02-13 16:56 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-08 15:55 [Qemu-devel] KVM call minutes for Feb 8 Chris Wright
2011-02-08 16:14 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-08 16:39 ` [Qemu-devel] " Anthony Liguori
2011-02-08 17:13 ` Markus Armbruster
2011-02-08 19:02 ` Peter Maydell
2011-02-08 21:11 ` Anthony Liguori
2011-02-09 8:11 ` Markus Armbruster
2011-02-09 8:20 ` Peter Maydell
2011-02-09 9:02 ` Markus Armbruster
2011-02-08 19:30 ` Alexander Graf
2011-02-08 19:30 ` Aurelien Jarno
2011-02-09 8:23 ` Markus Armbruster
2011-02-09 10:43 ` Anthony Liguori
2011-02-09 17:38 ` Blue Swirl
2011-02-08 21:12 ` Anthony Liguori
2011-02-09 8:01 ` Markus Armbruster
2011-02-09 10:31 ` Anthony Liguori
2011-02-09 12:28 ` Markus Armbruster
2011-02-09 14:44 ` Anthony Liguori
2011-02-09 17:48 ` Blue Swirl
2011-02-09 19:53 ` Anthony Liguori
2011-02-09 19:59 ` Anthony Liguori
2011-02-09 20:15 ` Blue Swirl
2011-02-10 7:47 ` Anthony Liguori
2011-02-10 8:16 ` Peter Maydell
2011-02-10 8:36 ` Anthony Liguori
2011-02-10 9:04 ` Peter Maydell
2011-02-10 10:13 ` Anthony Liguori
2011-02-10 10:38 ` Peter Maydell
2011-02-10 11:24 ` Gleb Natapov
2011-02-10 12:23 ` Anthony Liguori
2011-02-10 13:06 ` Peter Maydell
2011-02-10 19:17 ` Scott Wood
2011-02-10 19:22 ` Peter Maydell
2011-02-10 19:29 ` Scott Wood
2011-02-10 9:07 ` Gleb Natapov
2011-02-10 10:00 ` Anthony Liguori
2011-02-10 10:10 ` Gleb Natapov
2011-02-10 10:19 ` Anthony Liguori
2011-02-10 10:49 ` Gleb Natapov
2011-02-10 12:47 ` Anthony Liguori
2011-02-10 13:12 ` Gleb Natapov
2011-02-10 10:25 ` Avi Kivity
2011-02-10 11:13 ` Gleb Natapov
2011-02-10 12:51 ` Anthony Liguori
2011-02-10 13:00 ` Avi Kivity
2011-02-10 13:29 ` Gleb Natapov
2011-02-10 14:00 ` Anthony Liguori
2011-02-10 13:27 ` Gleb Natapov
2011-02-10 14:04 ` Anthony Liguori
2011-02-10 14:20 ` Gleb Natapov
2011-02-10 16:05 ` Anthony Liguori
2011-02-11 18:14 ` Blue Swirl
2011-02-13 9:24 ` Gleb Natapov
2011-02-13 15:31 ` Anthony Liguori
2011-02-13 19:37 ` Blue Swirl
2011-02-13 19:57 ` Anthony Liguori
2011-02-13 21:00 ` Blue Swirl
2011-02-13 22:42 ` Anthony Liguori
2011-02-14 17:31 ` Blue Swirl
2011-02-14 20:53 ` Anthony Liguori
2011-02-14 21:25 ` Blue Swirl
2011-02-14 21:47 ` Anthony Liguori
2011-02-15 17:11 ` Blue Swirl
2011-02-15 23:07 ` Anthony Liguori
2011-02-16 9:52 ` Gleb Natapov
2011-02-14 9:44 ` Paolo Bonzini
2011-02-10 10:29 ` Avi Kivity
2011-02-13 15:38 ` Anthony Liguori
2011-02-13 15:56 ` Avi Kivity
2011-02-13 16:56 ` Anthony Liguori [this message]
2011-02-13 18:08 ` Gleb Natapov
2011-02-13 19:38 ` Anthony Liguori
2011-02-14 10:23 ` Gleb Natapov
2011-02-13 21:24 ` Peter Maydell
2011-02-13 22:43 ` Anthony Liguori
2011-02-13 23:35 ` Peter Maydell
2011-02-13 15:39 ` Anthony Liguori
2011-02-11 17:54 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D580D3E.3000300@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=avi@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=chrisw@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).