Re: [Qemu-devel] [PATCH 02/10] parallel: make optional

[David Ahern <dsahern@gmail.com>]

On 02/12/11 15:40, Blue Swirl wrote:
> Ignore failure with parallel device creation.
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  hw/pc.h |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pc.h b/hw/pc.h
> index 443ba34..f823b7d 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -24,7 +24,10 @@ static inline bool parallel_init(int index,
> CharDriverState *chr)
>  {
>      ISADevice *dev;
> 
> -    dev = isa_create("isa-parallel");
> +    dev = isa_try_create("isa-parallel");
> +    if (!dev) {
> +        return false;
> +    }
>      qdev_prop_set_uint32(&dev->qdev, "index", index);
>      qdev_prop_set_chr(&dev->qdev, "chardev", chr);
>      if (qdev_init(&dev->qdev) < 0) {


How is this design supposed to be better than wrapping init functions in
#ifdef CONFIG_XXXX ... #endif?

If a hardware model is compiled out via the CONFIG options qemu should
fail to accept the command line parameters and not try to create the
device. Instead with this design it tries and fails to create the device
and yet continues on.

David