From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=44323 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PofmU-0001Dt-M5
	for qemu-devel@nongnu.org; Sun, 13 Feb 2011 12:30:44 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dsahern@gmail.com>) id 1PofmT-0000Yo-FY
	for qemu-devel@nongnu.org; Sun, 13 Feb 2011 12:30:42 -0500
Received: from mail-yi0-f45.google.com ([209.85.218.45]:47305)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dsahern@gmail.com>) id 1PofmT-0000YL-An
	for qemu-devel@nongnu.org; Sun, 13 Feb 2011 12:30:41 -0500
Received: by yie21 with SMTP id 21so1932933yie.4
	for <qemu-devel@nongnu.org>; Sun, 13 Feb 2011 09:30:39 -0800 (PST)
Message-ID: <4D58153B.8010506@gmail.com>
Date: Sun, 13 Feb 2011 10:30:35 -0700
From: David Ahern <dsahern@gmail.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 02/10] parallel: make optional
References: <AANLkTimVWX+4CYiqrpOQOMwH+SnUHPgbXHDGgQByg6r9@mail.gmail.com>
In-Reply-To: <AANLkTimVWX+4CYiqrpOQOMwH+SnUHPgbXHDGgQByg6r9@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel <qemu-devel@nongnu.org>



On 02/12/11 15:40, Blue Swirl wrote:
> Ignore failure with parallel device creation.
> 
> Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
> ---
>  hw/pc.h |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/hw/pc.h b/hw/pc.h
> index 443ba34..f823b7d 100644
> --- a/hw/pc.h
> +++ b/hw/pc.h
> @@ -24,7 +24,10 @@ static inline bool parallel_init(int index,
> CharDriverState *chr)
>  {
>      ISADevice *dev;
> 
> -    dev = isa_create("isa-parallel");
> +    dev = isa_try_create("isa-parallel");
> +    if (!dev) {
> +        return false;
> +    }
>      qdev_prop_set_uint32(&dev->qdev, "index", index);
>      qdev_prop_set_chr(&dev->qdev, "chardev", chr);
>      if (qdev_init(&dev->qdev) < 0) {


How is this design supposed to be better than wrapping init functions in
#ifdef CONFIG_XXXX ... #endif?

If a hardware model is compiled out via the CONFIG options qemu should
fail to accept the command line parameters and not try to create the
device. Instead with this design it tries and fails to create the device
and yet continues on.

David