From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=33737 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pow7W-00017m-O5 for qemu-devel@nongnu.org; Mon, 14 Feb 2011 05:57:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pow7V-0005bW-LD for qemu-devel@nongnu.org; Mon, 14 Feb 2011 05:57:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:41422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pow7V-0005bM-3w for qemu-devel@nongnu.org; Mon, 14 Feb 2011 05:57:29 -0500 Message-ID: <4D590A93.8080407@redhat.com> Date: Mon, 14 Feb 2011 11:57:23 +0100 From: Gerd Hoffmann MIME-Version: 1.0 References: <1296506599-7126-1-git-send-email-aliguori@us.ibm.com> In-Reply-To: <1296506599-7126-1-git-send-email-aliguori@us.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] vnc: Fix password expiration through 'change vnc ""' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Neil Wilson , qemu-devel@nongnu.org On 01/31/11 21:43, Anthony Liguori wrote: > commit 52c18be9e99dabe295321153fda7fce9f76647ac introduced a regression in the > change vnc password command that changed the behavior of setting the VNC > password to an empty string from disabling login to disabling authentication. > > This commit refactors the code to eliminate this overloaded semantics in > vnc_display_password and instead introduces the vnc_display_disable_login. The > monitor implementation then determines the behavior of an empty or missing > string. Hmm, now about simply never ever changing vs->auth? cheers, Gerd