From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=42913 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PpLVe-00071W-6w
	for qemu-devel@nongnu.org; Tue, 15 Feb 2011 09:04:13 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PpLVc-0001QW-9S
	for qemu-devel@nongnu.org; Tue, 15 Feb 2011 09:04:05 -0500
Received: from eu1sys200aog102.obsmtp.com ([207.126.144.113]:40182)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1PpLVb-0001Q6-Vn
	for qemu-devel@nongnu.org; Tue, 15 Feb 2011 09:04:04 -0500
Message-ID: <4D5A87CF.3090705@st.com>
Date: Tue, 15 Feb 2011 15:03:59 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 0/6] target-arm: Fix Neon shift
	instructions.
References: <1297437062-6118-1-git-send-email-christophe.lyon@st.com>
	<AANLkTikrQurQcgrJ0s88jDkx1a9a1vK5MvAJspG25tyO@mail.gmail.com>
In-Reply-To: <AANLkTikrQurQcgrJ0s88jDkx1a9a1vK5MvAJspG25tyO@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 14.02.2011 19:18, Peter Maydell wrote:
> On 11 February 2011 15:10,  <christophe.lyon@st.com> wrote:
>> From: Christophe Lyon <christophe.lyon@st.com>
>>
>> This patch series provides fixes such that ARM Neon instructions
>> VRSHR, VRSRA, VQRSHRN, VQRSHRUN, VRSHRN, VQSHRN, VSHRN, VQSHRUN now
>> pass all my tests.
>>
>> I have reworked all these patches and I hope they are now easier to
>> review.
> 
> Thanks; this was indeed a lot easier to review. Mostly
> this is OK, there are a few things:
>  * minor style issues
>  * handling of very large shift counts is not right
> (both in code you wrote and existing routines)

Yes, I mostly copied existing code to fix the parts I identified as wrong, but indeed very large shift amounts are not part of my tests.

>  * the shift-and-narrow loop doesn't handle the case
> where pass 1 reads registers pass 0 writes
> 
> I have patches which (sitting on top of your 6) fix all
> these and give a clean pass on the random instruction
> set testing for the shift instructions.
> 
> Unless you object, I think the simplest thing will be for
> me to just fix the minor nits I identified in your patches
> and then post a combined series of your patches and
> mine.
OK, thanks.

It also seems that the neon_shl_s* helpers don't handle correctly large negative shift amounts.

Christophe.