From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=46264 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PpdPY-0003DP-Gs for qemu-devel@nongnu.org; Wed, 16 Feb 2011 04:11:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PpdPX-0005d9-M5 for qemu-devel@nongnu.org; Wed, 16 Feb 2011 04:11:00 -0500 Received: from mx1.redhat.com ([209.132.183.28]:1990) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PpdPX-0005d3-BY for qemu-devel@nongnu.org; Wed, 16 Feb 2011 04:10:59 -0500 Message-ID: <4D5B9452.4020305@redhat.com> Date: Wed, 16 Feb 2011 11:09:38 +0200 From: Avi Kivity MIME-Version: 1.0 References: <7564d180e958415b388e0cb93e2f2a71.squirrel@webmail.iitd.ernet.in> <57F58C04-DDF3-4F8C-9BC3-DAED54D2D088@suse.de> <4D4C5149.80303@cse.iitd.ac.in> <7703D057-F12D-4B95-9AEE-190C4EB2A3CE@suse.de> <4D5A8BDB.1000206@cse.iitd.ac.in> <683A1DC5-CC47-492B-AEC0-29795890CEE8@suse.de> <4D5AA2C9.4030000@cse.iitd.ac.in> In-Reply-To: <4D5AA2C9.4030000@cse.iitd.ac.in> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: qemu compiling error on ppc64: kvm.c:81: error: 'struct kvm_sregs' has no member named 'pvr' List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dushyant Bansal Cc: Alexander Graf , "" , "qemu-devel@nongnu.org List" On 02/15/2011 05:59 PM, Dushyant Bansal wrote: >>> 2. How to configure makefiles to get output of printk statements >>> inside kvm/arch/powerpc/kvm/trace.h >> Better don't make them printks - just use the tracing framework. I'd >> write up a small howto here myself, but I'm pretty much on the jump >> to my plane for vacation. Avi, could you please guide him a bit on >> how to get data out of tracepoints? > Thanks for the quick reply :) > I have added some more trace parameters in the tracing framework and > currently, it is working fine. > 1. Add new field in "struct kvm_vcpu_stat" (kvm_host.h) > 2. Add corresponding entry in "struct kvm_stats_debugfs_item > debugfs_entries[]" (book3s.c) > 3. Increment or Decrement that field where ever necessary. Those aren't tracepoints; they're deprecated debug statistics. For tracepoints, see include/trace/events/kvm.h (general kvm tracepoints) arch/powerpc/kvm/trace.h (ppc specific tracepoints) arch/powerpc/kvm/book3s_mmu_hpte.c (examples of use, look for trace_kvm_*) Documentation/trace/tracepoints.txt (documentation, likely outdated) -- error compiling committee.c: too many arguments to function