From: Wen Congyang <wency@cn.fujitsu.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] uninit drive if drive_init failed
Date: Wed, 16 Feb 2011 17:58:58 +0800 [thread overview]
Message-ID: <4D5B9FE2.20903@cn.fujitsu.com> (raw)
In-Reply-To: <m3pqqspb2w.fsf@blackfin.pond.sub.org>
At 02/16/2011 05:45 PM, Markus Armbruster Write:
> Wen Congyang <wency@cn.fujitsu.com> writes:
>
>> steps to reproduce this bug:
>> 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file --driver qemu --subdriver qcow2
>> error: Failed to attach disk
>> error: operation failed: adding scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>>
>> 2. virsh attach-disk domain --source imagefile --target sdb --sourcetype file --driver qemu --subdriver raw
>> error: Failed to attach disk
>> error: operation failed: adding scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>>
>> The format of disk image file is raw.
>> If we run comand 2 only, we will attach the disk successfully.
>>
>> The reason of this bug is that: we do not remove dinfo from drives and dinfo->bdrv from bdrv_states
>> if we open the disk image file failed.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
>
> Already fixed in Kevin's block tree and 0.14-rc2 (commit 08931947),
> although not yet in stable.
I only use master tree and do not notice that this bug has been fixed.
Thank you for pointing it out.
>
> Thanks anyway!
>
prev parent reply other threads:[~2011-02-16 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 2:30 [Qemu-devel] [PATCH] uninit drive if drive_init failed Wen Congyang
2011-02-16 9:45 ` Markus Armbruster
2011-02-16 9:58 ` Wen Congyang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D5B9FE2.20903@cn.fujitsu.com \
--to=wency@cn.fujitsu.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).