From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54553 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PpeBp-0000cT-EN
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 05:00:54 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PpeBo-0000Iy-Lk
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 05:00:53 -0500
Received: from [222.73.24.84] (port=60210 helo=song.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <wency@cn.fujitsu.com>) id 1PpeBo-0000Im-D6
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 05:00:52 -0500
Message-ID: <4D5B9FE2.20903@cn.fujitsu.com>
Date: Wed, 16 Feb 2011 17:58:58 +0800
From: Wen Congyang <wency@cn.fujitsu.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] uninit drive if drive_init failed
References: <4D5B36B0.80804@cn.fujitsu.com>
	<m3pqqspb2w.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3pqqspb2w.fsf@blackfin.pond.sub.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>

At 02/16/2011 05:45 PM, Markus Armbruster Write:
> Wen Congyang <wency@cn.fujitsu.com> writes:
> 
>> steps to reproduce this bug:
>> 1. virsh attach-disk domain --source imagefile --target sdb --sourcetype file --driver qemu --subdriver qcow2
>> error: Failed to attach disk
>> error: operation failed: adding scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>>
>> 2. virsh attach-disk domain --source imagefile --target sdb --sourcetype file --driver qemu --subdriver raw
>> error: Failed to attach disk
>> error: operation failed: adding scsi-disk,bus=scsi0.0,scsi-id=1,drive=drive-scsi0-0-1,id=scsi0-0-1 device failed: Property 'scsi-disk.drive' can't find value 'drive-scsi0-0-1'
>>
>> The format of disk image file is raw.
>> If we run comand 2 only, we will attach the disk successfully.
>>
>> The reason of this bug is that: we do not remove dinfo from drives and dinfo->bdrv from bdrv_states
>> if we open the disk image file failed.
>>
>> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> 
> Already fixed in Kevin's block tree and 0.14-rc2 (commit 08931947),
> although not yet in stable.

I only use master tree and do not notice that this bug has been fixed.
Thank you for pointing it out.

> 
> Thanks anyway!
>