From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51480 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pph1C-0002x4-V8
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 08:02:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1Pph1B-0002sk-Ru
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 08:02:06 -0500
Received: from eu1sys200aog102.obsmtp.com ([207.126.144.113]:60585)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1Pph1B-0002rY-Kb
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 08:02:05 -0500
Message-ID: <4D5BCAC8.7090008@st.com>
Date: Wed, 16 Feb 2011 14:02:00 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] softfloat: export float32_nan and
	float32_infinity.
References: <4D595CB8.4020901@st.com>
	<AANLkTikpuYXqzDEqQJSRgmCAKFdUsseR=nFix0RWB0tB@mail.gmail.com>
In-Reply-To: <AANLkTikpuYXqzDEqQJSRgmCAKFdUsseR=nFix0RWB0tB@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 16.02.2011 12:53, Peter Maydell wrote:
> On 14 February 2011 16:47, Christophe Lyon <christophe.lyon@st.com> wrote:
>>
>> These two special values are needed to implement some helper functions, which return these values in some cases.
> 
> I assume this is for vrecpe, right? I think it would be better
> to post this as part of that patchset; it's easier to see the
> rationale for adding the functions when you also have the
> code that's using them.

Indeed. I'll post the bigger patch.

>>  /*----------------------------------------------------------------------------
>> +| Returns the default NaN.
>> +*----------------------------------------------------------------------------*/
>> +
>> +float32 float32_nan(void)
>> +{
>> +    return float32_default_nan;
>> +}
> 
> Maybe we should just expose float32_default_nan in
> softfloat.h somehow; that would match float32_zero,
> float32_one, etc (ie it would not be a function).
> 
It was my initial intention, but it implies adding a #if defined(TARGET_XXX) block in softfloat.h, and I feared this was not desirable.

Thanks.