From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=37615 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ppkhy-00018c-SC
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 11:58:32 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1Ppkhy-0005jV-8r
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 11:58:31 -0500
Received: from eu1sys200aog105.obsmtp.com ([207.126.144.119]:60265)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <christophe.lyon@st.com>) id 1Ppkhy-0005jK-06
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 11:58:30 -0500
Message-ID: <4D5C0232.20706@st.com>
Date: Wed, 16 Feb 2011 17:58:26 +0100
From: Christophe Lyon <christophe.lyon@st.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/2] softfloat: export float32_nan and
	float32_infinity.
References: <1297867883-18390-1-git-send-email-christophe.lyon@st.com>	<1297867883-18390-2-git-send-email-christophe.lyon@st.com>
	<AANLkTimfd-3QUfJaar_dG=WpeL4+DzEu_cSHkaABJq8s@mail.gmail.com>
In-Reply-To: <AANLkTimfd-3QUfJaar_dG=WpeL4+DzEu_cSHkaABJq8s@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>

On 16.02.2011 17:54, Peter Maydell wrote:
> On 16 February 2011 14:51,  <christophe.lyon@st.com> wrote:
>> From: Christophe Lyon <christophe.lyon@st.com>
>>
>> These two special values are needed to implement some helper
>> functions, which return these values in some cases.
>>
>> This patch also moves the definitions of default_nan for 16, 64, x80
>> and 128 bits floats for consistency with float32.
> 
> Your other patch only uses float32_infinity, not float32_nan
> or float32_default_nan, which renders a lot of this patch moot
> at the moment.

Indeed, I have another patch for vrsqrte which does need float32_nan.

>> +#define float32_nan float32_default_nan
> 
> If we do need to expose NaN, we should just have callers
> use float32_default_nan, there's no need for this extra
> #define.
>