[Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode

[Anthony Liguori <aliguori@linux.vnet.ibm.com>]

On 02/16/2011 01:48 PM, Stefan Weil wrote:
> Reverse mode is unusable:
>
> 	qemu -vnc localhost:5500,reverse
>
> crashes in vnc_refresh_server_surface because some pointers are NULL.
>
> Fix this by calling vnc_dpy_resize (which initializes these pointers)
> before calling vnc_refresh.
>
> Cc: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    

Nice catch!

Regards,

Anthony Liguori

> ---
>   ui/vnc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index da83adf..096b5f3 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
>       vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
>       if (vd->timer == NULL&&  !QTAILQ_EMPTY(&vd->clients)) {
>           vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
> +        vnc_dpy_resize(vd->ds);
>           vnc_refresh(vd);
>       }
>   }
>