From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53211 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ppno0-0006z6-Gr
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 15:17:01 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1Ppnnu-0005xM-D4
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 15:16:51 -0500
Received: from e34.co.us.ibm.com ([32.97.110.152]:55217)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1Ppnnu-0005xC-7y
	for qemu-devel@nongnu.org; Wed, 16 Feb 2011 15:16:50 -0500
Received: from d03relay03.boulder.ibm.com (d03relay03.boulder.ibm.com
	[9.17.195.228])
	by e34.co.us.ibm.com (8.14.4/8.13.1) with ESMTP id p1GK5NAP009580
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 13:05:23 -0700
Received: from d03av03.boulder.ibm.com (d03av03.boulder.ibm.com [9.17.195.169])
	by d03relay03.boulder.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p1GKGmnr123180
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 13:16:48 -0700
Received: from d03av03.boulder.ibm.com (loopback [127.0.0.1])
	by d03av03.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p1GKGltX021495
	for <qemu-devel@nongnu.org>; Wed, 16 Feb 2011 13:16:47 -0700
Message-ID: <4D5C309C.8010701@linux.vnet.ibm.com>
Date: Wed, 16 Feb 2011 14:16:28 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1297885680-17860-1-git-send-email-weil@mail.berlios.de>
In-Reply-To: <1297885680-17860-1-git-send-email-weil@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

On 02/16/2011 01:48 PM, Stefan Weil wrote:
> Reverse mode is unusable:
>
> 	qemu -vnc localhost:5500,reverse
>
> crashes in vnc_refresh_server_surface because some pointers are NULL.
>
> Fix this by calling vnc_dpy_resize (which initializes these pointers)
> before calling vnc_refresh.
>
> Cc: Anthony Liguori<aliguori@us.ibm.com>
> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>    

Nice catch!

Regards,

Anthony Liguori

> ---
>   ui/vnc.c |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/ui/vnc.c b/ui/vnc.c
> index da83adf..096b5f3 100644
> --- a/ui/vnc.c
> +++ b/ui/vnc.c
> @@ -2349,6 +2349,7 @@ static void vnc_init_timer(VncDisplay *vd)
>       vd->timer_interval = VNC_REFRESH_INTERVAL_BASE;
>       if (vd->timer == NULL&&  !QTAILQ_EMPTY(&vd->clients)) {
>           vd->timer = qemu_new_timer(rt_clock, vnc_refresh, vd);
> +        vnc_dpy_resize(vd->ds);
>           vnc_refresh(vd);
>       }
>   }
>