From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39025 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq2Zw-0003h5-Dq
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:03:26 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Pq2Zv-0008LV-At
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:03:24 -0500
Received: from mx1.redhat.com ([209.132.183.28]:28045)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kwolf@redhat.com>) id 1Pq2Zv-0008Kx-3n
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:03:23 -0500
Message-ID: <4D5D0EE4.1070603@redhat.com>
Date: Thu, 17 Feb 2011 13:04:52 +0100
From: Kevin Wolf <kwolf@redhat.com>
MIME-Version: 1.0
References: <cover.1297787220.git.mst@redhat.com>
In-Reply-To: <cover.1297787220.git.mst@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCHv2 0/3] e1000: multi-buffer packet support
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: stefanha@linux.vnet.ibm.com, Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, agraf@suse.de, Alex Williamson <alex.williamson@redhat.com>

Am 15.02.2011 17:27, schrieb Michael S. Tsirkin:
> e1000 supports multi-buffer packets larger than rxbuf_size.
> 
> This fixes the following (on linux):
> - in guest: ifconfig eth1 mtu 16110
> - in host: ifconfig tap0 mtu 16110
>            ping -s 16082 <guest-ip>
> 
> Red Hat bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=602205
> 
> Changes from v1:
> 	fix buffer overflow reported by Kevin
> 	added a patch to fix EOP spec violation reported by Juan
> 	added a patch to fix spec violation noted by myself
> 
> 
> Michael S. Tsirkin (3):
>   e1000: multi-buffer packet support
>   e1000: clear EOP for multi-buffer descriptors
>   e1000: verify we have buffers, upfront
> 
>  hw/e1000.c |   61 +++++++++++++++++++++++++++++++++++++++++++++++------------
>  1 files changed, 48 insertions(+), 13 deletions(-)

I found patch 3 to be not that easy to understand (especially the
s->check_rxov part), but after thinking a while about it, it seems to
make sense.

Acked-by: Kevin Wolf <kwolf@redhat.com>