From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34834 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq2mj-0003bQ-Kh
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:16:38 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pq2mh-0002Uv-O2
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:16:37 -0500
Received: from mail-ew0-f45.google.com ([209.85.215.45]:33071)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1Pq2mh-0002Um-Ia
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:16:35 -0500
Received: by ewy10 with SMTP id 10so949325ewy.4
	for <qemu-devel@nongnu.org>; Thu, 17 Feb 2011 04:16:34 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D5D119E.6070602@redhat.com>
Date: Thu, 17 Feb 2011 13:16:30 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1297773281-4959-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1297773281-4959-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to
 specify dtrace probe names
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 02/15/2011 01:34 PM, Jes.Sorensen@redhat.com wrote:
> -    if [ -z "$binary" ]; then
> +    if [ -z "$probeprefix" -a -z "$binary" ]; then
>          echo "--binary is required for SystemTAP tapset generator"
>          exit 1
>       fi

--binary is always required, even with --probe-prefix, since it is used for

+probe $probeprefix.$name = process("$binary").mark("$name")

Paolo