From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=54438 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq31D-00040S-JC
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:31:40 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pq2zE-0007Kd-9t
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:29:33 -0500
Received: from mx1.redhat.com ([209.132.183.28]:24345)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pq2zD-0007K2-V3
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:29:32 -0500
Message-ID: <4D5D14A7.6090007@redhat.com>
Date: Thu, 17 Feb 2011 13:29:27 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1297773281-4959-1-git-send-email-Jes.Sorensen@redhat.com>
	<4D5D119E.6070602@redhat.com> <4D5D1235.70202@redhat.com>
In-Reply-To: <4D5D1235.70202@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v2] tracetool: Add optional argument to
 specify dtrace probe names
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes Sorensen <Jes.Sorensen@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 02/17/2011 01:19 PM, Jes Sorensen wrote:
> On 02/17/11 13:16, Paolo Bonzini wrote:
>> On 02/15/2011 01:34 PM, Jes.Sorensen@redhat.com wrote:
>>> -    if [ -z "$binary" ]; then
>>> +    if [ -z "$probeprefix" -a -z "$binary" ]; then
>>>           echo "--binary is required for SystemTAP tapset generator"
>>>           exit 1
>>>        fi
>>
>> --binary is always required, even with --probe-prefix, since it is used for
>>
>> +probe $probeprefix.$name = process("$binary").mark("$name")
>
> if I broke something with this

No, you didn't break anything.  It's just that someone patching the 
Makefile like you did in 2/2 might.

Paolo