From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=52112 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq30y-0002oi-2Y
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:31:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pq30E-0007yj-9H
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:30:36 -0500
Received: from mx1.redhat.com ([209.132.183.28]:31074)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Pq30E-0007yC-0w
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 07:30:34 -0500
Message-ID: <4D5D14BF.1060309@redhat.com>
Date: Thu, 17 Feb 2011 13:29:51 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1297945565-10593-1-git-send-email-Jes.Sorensen@redhat.com>
In-Reply-To: <1297945565-10593-1-git-send-email-Jes.Sorensen@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH v3] tracetool: Add optional argument to
 specify dtrace probe names
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jes.Sorensen@redhat.com
Cc: qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

On 02/17/2011 01:26 PM, Jes.Sorensen@redhat.com wrote:
> From: Jes Sorensen<Jes.Sorensen@redhat.com>
>
> Optional feature allowing a user to generate the probe list to match
> the name of the binary, in case they wish to install qemu under a
> different name than qemu-{system,user},<arch>
>
> Signed-off-by: Jes Sorensen<Jes.Sorensen@redhat.com>
> ---
>   scripts/tracetool |   19 +++++++++++++------
>   1 files changed, 13 insertions(+), 6 deletions(-)
>
> diff --git a/scripts/tracetool b/scripts/tracetool
> index e046683..412f695 100755
> --- a/scripts/tracetool
> +++ b/scripts/tracetool
> @@ -30,9 +30,11 @@ Output formats:
>     --stap Generate .stp file (DTrace with SystemTAP only)
>
>   Options:
> -  --binary      [path]  Full path to QEMU binary
> -  --target-arch [arch]  QEMU emulator target arch
> -  --target-type [type]  QEMU emulator target type ('system' or 'user')
> +  --binary       [path]    Full path to QEMU binary
> +  --target-arch  [arch]    QEMU emulator target arch
> +  --target-type  [type]    QEMU emulator target type ('system' or 'user')
> +  --probe-prefix [prefix]  Prefix for dtrace probe names
> +                           (default: qemu-\$targettype-\$targetarch)
>
>   EOF
>       exit 1
> @@ -472,7 +474,7 @@ linetostap_dtrace()
>
>       # Define prototype for probe arguments
>       cat<<EOF
> -probe qemu.$targettype.$targetarch.$name = process("$binary").mark("$name")
> +probe $probeprefix.$name = process("$binary").mark("$name")
>   {
>   EOF
>
> @@ -574,14 +576,17 @@ tracetostap()
>          echo "--binary is required for SystemTAP tapset generator"
>          exit 1
>       fi
> -    if [ -z "$targettype" ]; then
> +    if [ -z "$probeprefix" -a -z "$targettype" ]; then
>          echo "--target-type is required for SystemTAP tapset generator"
>          exit 1
>       fi
> -    if [ -z "$targetarch" ]; then
> +    if [ -z "$probeprefix" -a -z "$targetarch" ]; then
>          echo "--target-arch is required for SystemTAP tapset generator"
>          exit 1
>       fi
> +    if [ -z "$probeprefix" ]; then
> +	probeprefix="qemu.$targettype.$targetarch";
> +    fi
>       echo "/* This file is autogenerated by tracetool, do not edit. */"
>       convert stap
>   }
> @@ -592,6 +597,7 @@ output=
>   binary=
>   targettype=
>   targetarch=
> +probeprefix=
>
>
>   until [ -z "$1" ]
> @@ -602,6 +608,7 @@ do
>       "--binary") shift ; binary="$1" ;;
>       "--target-arch") shift ; targetarch="$1" ;;
>       "--target-type") shift ; targettype="$1" ;;
> +    "--probe-prefix") shift ; probeprefix="$1" ;;
>
>       "-h" | "-c" | "-d") output="${1#-}" ;;
>       "--stap") output="${1#--}" ;;

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo