From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=53444 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq3eU-0006Ae-AG
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:12:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pq3eT-0005wZ-75
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:12:10 -0500
Received: from mail-vx0-f173.google.com ([209.85.220.173]:39428)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pq3eT-0005wV-4y
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 08:12:09 -0500
Received: by vxb40 with SMTP id 40so1128185vxb.4
	for <qemu-devel@nongnu.org>; Thu, 17 Feb 2011 05:12:08 -0800 (PST)
Message-ID: <4D5D1E90.4080501@codemonkey.ws>
Date: Thu, 17 Feb 2011 07:11:44 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH REBASE/RESEND 2/4] virtio-serial: Add
	description fields for qdev properties
References: <cover.1296800129.git.amit.shah@redhat.com>	<2b49a1453925f808405eb380cab2f45f10fb6a5f.1296800130.git.amit.shah@redhat.com>	<4D5AA56F.9040901@codemonkey.ws>
	<20110217130324.GC27487@amit-x200.redhat.com>
In-Reply-To: <20110217130324.GC27487@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu list <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>

On 02/17/2011 07:03 AM, Amit Shah wrote:
> On (Tue) 15 Feb 2011 [10:10:23], Anthony Liguori wrote:
>
>    
>>> diff --git a/hw/virtio-serial.h b/hw/virtio-serial.h
>>> index a308196..2c5e336 100644
>>> --- a/hw/virtio-serial.h
>>> +++ b/hw/virtio-serial.h
>>> @@ -57,6 +57,19 @@ struct virtio_console_control {
>>>
>>>   /* == In-qemu interface == */
>>>
>>> +#define PROP_VIRTSERIAL_IS_CONSOLE_DESC                                 \
>>> +    "An hvc console will be spawned in the guest if this is set."
>>> +
>>> +#define PROP_VIRTSERIAL_NR_DESC                                         \
>>> +    "The 'number' for the port for predictable port numbers. Use this to " \
>>> +    "spawn ports if you plan to migrate the guest."
>>> +
>>> +#define PROP_VIRTSERIAL_CHR_DESC                \
>>> +    "The chardev to associate this port with."
>>> +
>>> +#define PROP_VIRTSERIAL_NAME_DESC                \
>>> +    "Name for the port that's exposed to the guest for port discovery."
>>> +
>>>        
>> Why are you using a #define instead of inlining the docs?
>>      
> These are shared by the generic and console ports.
>    

Are the properties the same?  Should a common properties define be used 
like with network and disk devices?

Regards,

Anthony Liguori

> 		Amit
>
>