qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Tristan Gingold <gingold@adacore.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] Use sigwait instead og sigwaitinfo.
Date: Thu, 17 Feb 2011 18:06:02 +0100	[thread overview]
Message-ID: <4D5D557A.2060109@redhat.com> (raw)
In-Reply-To: <1297959841-41235-1-git-send-email-gingold@adacore.com>

On 02/17/2011 05:24 PM, Tristan Gingold wrote:
> -        siginfo_t siginfo;
> +        int sig;
>
> -        err = sigwaitinfo(&info->mask,&siginfo);
> +        err = sigwait(&info->mask,&sig);

This is doable but the patch is wrong, after sigwaitinfo "err" is the 
signal number, so you should replace

             memcpy(buffer, &err, sizeof(err));

further down with

             memcpy(buffer, &sig, sizeof(sig));

Paolo

  reply	other threads:[~2011-02-17 17:06 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-17 16:24 [Qemu-devel] [PATCH] Use sigwait instead og sigwaitinfo Tristan Gingold
2011-02-17 17:06 ` Paolo Bonzini [this message]
2011-02-18 13:17 ` [Qemu-devel] [PATCH] Use sigwait instead of sigwaitinfo Tristan Gingold
2011-02-18 14:09   ` [Qemu-devel] " Paolo Bonzini
2011-02-18 15:34   ` Jan Kiszka
2011-02-18 15:50     ` Tristan Gingold
2011-02-18 16:16       ` Jan Kiszka
2011-02-18 18:15   ` [Qemu-devel] " Blue Swirl
2011-02-25 20:58   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D5D557A.2060109@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=gingold@adacore.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).