From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36796 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pq8Pl-0003lZ-Pq
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:17:18 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Pq8Pj-0006Vr-Np
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:17:17 -0500
Received: from david.siemens.de ([192.35.17.14]:18003)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1Pq8Pj-0006VH-C4
	for qemu-devel@nongnu.org; Thu, 17 Feb 2011 13:17:15 -0500
Message-ID: <4D5D6620.4030008@siemens.com>
Date: Thu, 17 Feb 2011 19:17:04 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <cover.1297758211.git.jan.kiszka@siemens.com>
	<67f48a7cb1aebebb1dc4af0f413379686dcff24b.1297758211.git.jan.kiszka@siemens.com>
	<20110217180858.GB12113@amt.cnet>
In-Reply-To: <20110217180858.GB12113@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 09/13] kvm: x86: Consolidate TCG and KVM
 MCE injection code
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Avi Kivity <avi@redhat.com>, Huang Ying <ying.huang@intel.com>, Jin Dongming <jin.dongming@np.css.fujitsu.com>

On 2011-02-17 19:08, Marcelo Tosatti wrote:
> On Tue, Feb 15, 2011 at 09:23:33AM +0100, Jan Kiszka wrote:
>> This switches KVM's MCE injection path to cpu_x86_inject_mce, both for
>> SIGBUS and monitor initiated events. This means we prepare the MCA MSRs
>> in the VCPUState also for KVM.
>>
>> We have to drop the MSRs writeback restrictions for this purpose which
>> is now safe as every uncoordinated MSR injection is removed with this
>> patch.
>>
>> We have to execute every per-VCPU event setup on the target VCPU as we
>> are performing a read-modify-write on its state.
>>
>> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
>> CC: Huang Ying <ying.huang@intel.com>
>> CC: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
>> CC: Jin Dongming <jin.dongming@np.css.fujitsu.com>
> 
> Difficult to review, please split:
> 
> - drop writeback restriction

That will not work due to mutual dependency (see changelog)...

> - unify monitor/sigbus injection paths 
> - cleanup / refactor
> 

...but I will check again and filter out potential cleanups that could
be done afterwards.

Jan

-- 
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux