From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47109 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PqTvN-00081Z-Qb
	for qemu-devel@nongnu.org; Fri, 18 Feb 2011 12:15:22 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PqTtt-0001MV-La
	for qemu-devel@nongnu.org; Fri, 18 Feb 2011 12:13:51 -0500
Received: from lo.gmane.org ([80.91.229.12]:48784)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PqTtt-0001Lu-GH
	for qemu-devel@nongnu.org; Fri, 18 Feb 2011 12:13:49 -0500
Received: from list by lo.gmane.org with local (Exim 4.69)
	(envelope-from <gceq-qemu-devel@m.gmane.org>) id 1PqTtm-0003tK-7D
	for qemu-devel@nongnu.org; Fri, 18 Feb 2011 18:13:42 +0100
Received: from 93-34-149-100.ip50.fastwebnet.it ([93.34.149.100])
	by main.gmane.org with esmtp (Gmexim 0.1 (Debian))
	id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 18 Feb 2011 18:13:42 +0100
Received: from pbonzini by 93-34-149-100.ip50.fastwebnet.it with local (Gmexim
	0.1 (Debian)) id 1AlnuQ-0007hv-00
	for <qemu-devel@nongnu.org>; Fri, 18 Feb 2011 18:13:42 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
Date: Fri, 18 Feb 2011 18:13:27 +0100
Message-ID: <4D5EA8B7.3080206@redhat.com>
References: <20110215175410.GA13487@amt.cnet>
	<4D5ACCED.1080906@siemens.com>	<20110215200446.GA15802@amt.cnet>
	<4D5AE2FC.4020309@web.de>	<20110215205504.GA16527@amt.cnet>	<20110215205631.GA16579@amt.cnet>
	<4D5B99A9.1010404@redhat.com>	<20110217031538.GA22552@amt.cnet>
	<4D5CDBFF.3030808@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
In-Reply-To: <4D5CDBFF.3030808@redhat.com>
Subject: [Qemu-devel] Re: [PATCH] fix halt emulation with icount and
	CONFIG_IOTHREAD (v2)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Marcelo Tosatti <mtosatti@redhat.com>, Jan Kiszka <jan.kiszka@web.de>

On 02/17/2011 09:27 AM, Paolo Bonzini wrote:
> It is "-icount N" which is broken and unfortunately your patch does not
> fix it.

The problem is that for "use_icount == 1" qemu_icount_delta always 
returns 0, and this makes no sense in the iothread case.  As soon as the 
delta becomes greater than 10 ms (the maximum adjustment in 
qemu_calculate_timeout) you just keep polling but hardly execute any code.

I'll try to post something in the weekend.

Paolo