From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47372 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pr5Ae-0005BX-30 for qemu-devel@nongnu.org; Sun, 20 Feb 2011 04:01:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pr5Ad-0007l5-2Y for qemu-devel@nongnu.org; Sun, 20 Feb 2011 04:01:36 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:50323) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pr5Ac-0007l0-Kl for qemu-devel@nongnu.org; Sun, 20 Feb 2011 04:01:35 -0500 Message-ID: <4D60D86C.6090604@web.de> Date: Sun, 20 Feb 2011 10:01:32 +0100 From: Jan Kiszka MIME-Version: 1.0 Subject: Re: [Qemu-devel] [STABLE][PATCH] isa-bus: Remove bogus IRQ sharing check References: <4D600446.3070008@web.de> <4D6047EE.50707@msgid.tls.msk.ru> In-Reply-To: <4D6047EE.50707@msgid.tls.msk.ru> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig6209754F3EE41BFE24A0C1F6" Sender: jan.kiszka@web.de List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: Kevin Wolf , qemu-devel , Alexander Graf , =?ISO-8859-15?Q?Andreas_F=E4rber?= , Gerd Hoffmann , Aurelien Jarno This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig6209754F3EE41BFE24A0C1F6 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-02-19 23:45, Michael Tokarev wrote: > 19.02.2011 20:56, Jan Kiszka wrote: >> From: Jan Kiszka >> >> Nothing prevented IRQ sharing on the ISA bus in principle. Not all >> boards supported this, neither each and every card nor driver and OS. >> Still, there existed valid IRQ sharing scenarios, (at least) two of th= em >> can also be found in QEMU: >2 PC UARTs and the PREP IDE buses. >> >> So remove this artificial restriction from our ISA model and reenable >> both PREP IDE buses. >=20 > In qemu-kvm at least (I don't remember how different the relevant code > has been between qemu and qemu-kvm at that time) this restriction exist= s Both trees should not have had any differences in this area. > since 0.12 version. Before that it was at least possible to have >2 UA= RTS. > Do you aware of this? I don't know this code at all, so.. just asking = :) Oh, we have this since 0.13? Well... >=20 > I'd love to get this fixed for real instead of a hackish way we did thi= s > in the debian package, and it does not look like the change is problema= tic, > but are you sure it should go to stable? If we agree that removing is correct (I'm strongly convinced about this), than at least 0.14.1 should benefit from it. >=20 > FWIW, I applied this patch to qemu-kvm 0.14 branch (had to hand-apply > it to hw/pc.c, obvious s/isa_reserve_irq/isa_get_irq) and run some quic= k > tests, it appears to work correctly here with multiple serial ports > and e.g. serial console on ttyS4. >=20 > (Without the patch (and this is a separate bug), qemu-kvm prints: >=20 > qemu: hardware error: isa irq 4 already assigned > CPU #0: > _ >=20 > when asked to create 3 serial ports, and stays there till killed). Yeah, saw this at well but somehow ignored it. It's a KVM bug, upstream is fixed like this: diff --git a/kvm-all.c b/kvm-all.c index e6a7de4..e54b5bf 100644 --- a/kvm-all.c +++ b/kvm-all.c @@ -211,6 +211,7 @@ int kvm_init_vcpu(CPUState *env) env->kvm_fd =3D ret; env->kvm_state =3D s; + env->kvm_vcpu_dirty =3D 1; mmap_size =3D kvm_ioctl(s, KVM_GET_VCPU_MMAP_SIZE, 0); if (mmap_size < 0) { Will queue this for uq/master and post a corresponding qemu-kvm patch. Thanks for pointing out! Jan --------------enig6209754F3EE41BFE24A0C1F6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk1g2GwACgkQitSsb3rl5xSZZgCfR+IPsi+TlN37c75NMpB9aFUt pTcAn097hvNvp5gK4/EawAgRADGZI6zd =nztt -----END PGP SIGNATURE----- --------------enig6209754F3EE41BFE24A0C1F6--