From: Paolo Bonzini <pbonzini@redhat.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 2/7] implement win32 dynticks timer
Date: Mon, 21 Feb 2011 09:07:57 +0100 [thread overview]
Message-ID: <4D621D5D.5040807@redhat.com> (raw)
In-Reply-To: <AANLkTimzDT0R3n3ddn6_T-wLmCCjBhJprdp5oLcHauMi@mail.gmail.com>
On 02/20/2011 10:15 PM, Blue Swirl wrote:
> On Thu, Feb 10, 2011 at 7:37 PM, Paolo Bonzini<pbonzini@redhat.com> wrote:
>> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
>> Cc: Stefan Weil<weil@mail.berlios.de>
>> Cc: Blue Swirl<blauwirbel@gmail.com>
>> ---
>> qemu-timer.c | 6 +++++-
>> 1 files changed, 5 insertions(+), 1 deletions(-)
>>
>> diff --git a/qemu-timer.c b/qemu-timer.c
>> index b0db780..42960de 100644
>> --- a/qemu-timer.c
>> +++ b/qemu-timer.c
>> @@ -1006,6 +1006,7 @@ static void win32_stop_timer(struct qemu_alarm_timer *t)
>> static void win32_rearm_timer(struct qemu_alarm_timer *t)
>> {
>> struct qemu_alarm_win32 *data = t->priv;
>> + int nearest_delta_ms;
>>
>> assert(alarm_has_dynticks(t));
>> if (!active_timers[QEMU_CLOCK_REALTIME]&&
>> @@ -1015,7 +1016,10 @@ static void win32_rearm_timer(struct qemu_alarm_timer *t)
>>
>> timeKillEvent(data->timerId);
>>
>> - data->timerId = timeSetEvent(1,
>> + nearest_delta_ms = (qemu_next_alarm_deadline() + 999999) / 1000000;
>> + if (nearest_delta_ms< 1)
>> + nearest_delta_ms = 1;
>
> Braces, please.
Oops, checkpatch missed it. Will fix.
Paolo
next prev parent reply other threads:[~2011-02-21 8:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-10 17:37 [Qemu-devel] [PATCH 0/7] Win32 queue, part 1 Paolo Bonzini
2011-02-10 17:37 ` [Qemu-devel] [PATCH 1/7] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-10 17:37 ` [Qemu-devel] [PATCH 2/7] implement win32 dynticks timer Paolo Bonzini
2011-02-20 21:15 ` [Qemu-devel] " Blue Swirl
2011-02-21 8:07 ` Paolo Bonzini [this message]
2011-02-10 17:37 ` [Qemu-devel] [PATCH 3/7] use win32 timer queues Paolo Bonzini
2011-02-10 17:37 ` [Qemu-devel] [PATCH 4/7] add win32 qemu-thread implementation Paolo Bonzini
2011-02-10 19:46 ` [Qemu-devel] " Stefan Weil
2011-02-11 12:28 ` Paolo Bonzini
2011-02-20 21:11 ` Blue Swirl
2011-02-10 17:37 ` [Qemu-devel] [PATCH 5/7] include qemu-thread.h early Paolo Bonzini
2011-02-10 17:37 ` [Qemu-devel] [PATCH 6/7] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-10 18:25 ` [Qemu-devel] " Jan Kiszka
2011-02-11 12:14 ` Paolo Bonzini
2011-02-11 12:54 ` Jan Kiszka
2011-02-10 17:37 ` [Qemu-devel] [PATCH 7/7] remove CONFIG_THREAD Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D621D5D.5040807@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).