From: Jan Kiszka <jan.kiszka@siemens.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH 21/21] add Win32 IPI service
Date: Mon, 21 Feb 2011 13:25:52 +0100 [thread overview]
Message-ID: <4D6259D0.8090608@siemens.com> (raw)
In-Reply-To: <4D625758.8020202@redhat.com>
On 2011-02-21 13:15, Paolo Bonzini wrote:
> On 02/21/2011 01:00 PM, Jan Kiszka wrote:
>> qemu_thread_* services do not truly belong here.
>>
>> What about defining SIG_IPI as QEMU_SIG_KICK which would be provided by
>> qemu-thread-posix.h? Then the qemu-thread-posix.c could implement
>> qemu_thread_kick() again.
>
> The function is really specific to VCPU threads. It is simply a wrapper
> for the common bit of qemu_kick_vcpu and qemu_mutex_lock_iothread. I'll
> rename it to qemu_cpu_kick_thread and make it accept a CPUState.
...or that way. We should just try to respect the abstraction layers.
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2011-02-21 12:25 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-21 8:43 [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 01/21] unlock iothread during WaitForMultipleObjects Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 02/21] implement win32 dynticks timer Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 03/21] use win32 timer queues Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 04/21] replace qemu_thread_equal API with qemu_thread_is_current Paolo Bonzini
2011-02-21 9:41 ` [Qemu-devel] " Jan Kiszka
2011-02-21 11:14 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 05/21] add win32 qemu-thread implementation Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 06/21] include qemu-thread.h early Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 07/21] add assertions on the owner of a QemuMutex Paolo Bonzini
2011-02-21 9:50 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:15 ` Paolo Bonzini
2011-02-21 10:22 ` Jan Kiszka
2011-02-21 10:23 ` Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 08/21] remove CONFIG_THREAD Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 09/21] inline cpu_halted into sole caller Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 10/21] always qemu_cpu_kick after unhalting a cpu Paolo Bonzini
2011-02-21 9:51 ` [Qemu-devel] " Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 11/21] exit round-robin vcpu loop if cpu->stopped is true Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 12/21] always signal pause_cond after stopping a VCPU Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 13/21] do not use timedwait on qemu_halt_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 14/21] do not use timedwait on qemu_system_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 15/21] do not use timedwait on qemu_pause_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 16/21] do not use timedwait on qemu_cpu_cond Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 17/21] iothread stops the vcpu thread via IPI Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 18/21] move blocking of signals to qemu_signalfd_init Paolo Bonzini
2011-02-21 10:12 ` [Qemu-devel] " Jan Kiszka
2011-02-21 10:20 ` Paolo Bonzini
2011-02-21 10:26 ` Jan Kiszka
2011-02-21 8:43 ` [Qemu-devel] [PATCH 19/21] provide dummy signal init functions for win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 20/21] protect qemu_cpu_kick_self for Win32 Paolo Bonzini
2011-02-21 8:43 ` [Qemu-devel] [PATCH 21/21] add Win32 IPI service Paolo Bonzini
2011-02-21 12:00 ` [Qemu-devel] " Jan Kiszka
2011-02-21 12:15 ` Paolo Bonzini
2011-02-21 12:25 ` Jan Kiszka [this message]
2011-02-22 20:35 ` [Qemu-devel] [PATCH uq/master 00/21] Win32 iothread support Anthony Liguori
2011-02-23 7:29 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6259D0.8090608@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).