From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54945 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrUpy-000775-JO for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:25:59 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrUpx-0002Zn-Sl for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:25:58 -0500 Received: from thoth.sbs.de ([192.35.17.2]:21153) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrUpx-0002ZI-KM for qemu-devel@nongnu.org; Mon, 21 Feb 2011 07:25:57 -0500 Message-ID: <4D6259D0.8090608@siemens.com> Date: Mon, 21 Feb 2011 13:25:52 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1298277820-8817-1-git-send-email-pbonzini@redhat.com> <1298277820-8817-22-git-send-email-pbonzini@redhat.com> <4D6253E4.9070400@siemens.com> <4D625758.8020202@redhat.com> In-Reply-To: <4D625758.8020202@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 21/21] add Win32 IPI service List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: "qemu-devel@nongnu.org" On 2011-02-21 13:15, Paolo Bonzini wrote: > On 02/21/2011 01:00 PM, Jan Kiszka wrote: >> qemu_thread_* services do not truly belong here. >> >> What about defining SIG_IPI as QEMU_SIG_KICK which would be provided by >> qemu-thread-posix.h? Then the qemu-thread-posix.c could implement >> qemu_thread_kick() again. > > The function is really specific to VCPU threads. It is simply a wrapper > for the common bit of qemu_kick_vcpu and qemu_mutex_lock_iothread. I'll > rename it to qemu_cpu_kick_thread and make it accept a CPUState. ...or that way. We should just try to respect the abstraction layers. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux