From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@gmail.com>
Cc: hch@infradead.org, Jes.Sorensen@redhat.com,
qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com
Subject: Re: [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write
Date: Tue, 22 Feb 2011 16:11:19 +0100 [thread overview]
Message-ID: <4D63D217.9080206@redhat.com> (raw)
In-Reply-To: <AANLkTimrQXxX-4eAmcJstB8g_apaaDqoCf6twhd2t=_D@mail.gmail.com>
Am 22.02.2011 16:02, schrieb Stefan Hajnoczi:
> On Tue, Feb 22, 2011 at 10:18 AM, <Jes.Sorensen@redhat.com> wrote:
>> + else if ((laiocb->type == QEMU_AIO_WRITE) && (ret >= 0) &&
>> + (ret < laiocb->nbytes))
>> + ret = -ENOSPC;
>
> Why is write special?
I think we need the change reads, too. However not to return ENOSPC, but
to return zeros instead (this is what the synchronous raw_read does, and
pwrite relies on it - once we make pwrite async, we'll need this).
> Why are we even allowing requests that extend beyond the end of the
> device? Is the LVM volume marked growable in the QEMU block layer?
Might well be a qcow2 on LVM case that Jes was debugging.
Kevin
next prev parent reply other threads:[~2011-02-22 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-22 10:17 [Qemu-devel] [PATCH] For AIO return -ENOSPC on short write Jes.Sorensen
2011-02-22 10:18 ` Jes.Sorensen
2011-02-22 11:44 ` [Qemu-devel] " Kevin Wolf
2011-02-22 11:45 ` Jes Sorensen
2011-02-22 13:56 ` Avi Kivity
2011-02-22 15:02 ` [Qemu-devel] " Stefan Hajnoczi
2011-02-22 15:11 ` Kevin Wolf [this message]
2011-02-22 15:16 ` Stefan Hajnoczi
2011-02-22 16:59 ` [Qemu-devel] " Paolo Bonzini
2011-03-01 20:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D63D217.9080206@redhat.com \
--to=kwolf@redhat.com \
--cc=Jes.Sorensen@redhat.com \
--cc=hch@infradead.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@gmail.com \
--cc=stefanha@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).