From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=47322 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsAcn-0007sc-QJ for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:03:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsAcm-0004l1-Ph for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:03:09 -0500 Received: from mail-ew0-f45.google.com ([209.85.215.45]:48087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsAcm-0004kb-Fz for qemu-devel@nongnu.org; Wed, 23 Feb 2011 04:03:08 -0500 Received: by ewy24 with SMTP id 24so1913094ewy.4 for ; Wed, 23 Feb 2011 01:03:07 -0800 (PST) Sender: Paolo Bonzini Message-ID: <4D64CD48.4080700@redhat.com> Date: Wed, 23 Feb 2011 10:03:04 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 00/22] Refactor and cleaup migration code List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org On 02/23/2011 01:44 AM, Juan Quintela wrote: > This series: > - Fold MigrationState into FdMigrationState (and then rename) > - Factorize migration statec creation in a single place > - Make use of MIG_STATE_*, setup through helpers and make them local > - remove relase& cancel callbacks (where used only one in same > file than defined) > - get_status() is no more, just access directly to .state > - current_migration use cleanup, and make variable static > - max_throotle is gone, now inside current_migration > - change get_migration_status() to migration_has_finished() > and actualize single user. > > Please review. Some changes are a matter of taste, but overall looks very nice! Reviewed-by: Paolo Bonzini Paolo