From: Stefan Weil <weil@mail.berlios.de>
To: Anthony Liguori <aliguori@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
Date: Wed, 23 Feb 2011 22:57:31 +0100 [thread overview]
Message-ID: <4D6582CB.4050503@mail.berlios.de> (raw)
In-Reply-To: <4D5C309C.8010701@linux.vnet.ibm.com>
Am 16.02.2011 21:16, schrieb Anthony Liguori:
> On 02/16/2011 01:48 PM, Stefan Weil wrote:
>> Reverse mode is unusable:
>>
>> qemu -vnc localhost:5500,reverse
>>
>> crashes in vnc_refresh_server_surface because some pointers are NULL.
>>
>> Fix this by calling vnc_dpy_resize (which initializes these pointers)
>> before calling vnc_refresh.
>>
>> Cc: Anthony Liguori<aliguori@us.ibm.com>
>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>
> Nice catch!
>
> Regards,
>
> Anthony Liguori
What now? Will the patch be committed, is there a different fix for this
bug,
or are you planning to remove vnc because it is unmaintained?
Stefan
next prev parent reply other threads:[~2011-02-23 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 19:48 [Qemu-devel] [PATCH] vnc: Fix fatal crash with vnc reverse mode Stefan Weil
2011-02-16 20:16 ` [Qemu-devel] " Anthony Liguori
2011-02-23 21:57 ` Stefan Weil [this message]
2011-02-23 23:24 ` Anthony Liguori
2011-02-23 23:23 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6582CB.4050503@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=aliguori@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).