From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46604 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsO4E-00049p-Pk
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 18:24:23 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PsO4D-00088g-Ey
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 18:24:22 -0500
Received: from e9.ny.us.ibm.com ([32.97.182.139]:42213)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aliguori@linux.vnet.ibm.com>) id 1PsO4D-00088X-8d
	for qemu-devel@nongnu.org; Wed, 23 Feb 2011 18:24:21 -0500
Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234])
	by e9.ny.us.ibm.com (8.14.4/8.13.1) with ESMTP id p1NMwWHG008025
	for <qemu-devel@nongnu.org>; Wed, 23 Feb 2011 17:58:32 -0500
Received: from d03av01.boulder.ibm.com (d03av01.boulder.ibm.com [9.17.195.167])
	by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id
	p1NNOKln390398
	for <qemu-devel@nongnu.org>; Wed, 23 Feb 2011 18:24:20 -0500
Received: from d03av01.boulder.ibm.com (loopback [127.0.0.1])
	by d03av01.boulder.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP
	id p1NNOJD3008393
	for <qemu-devel@nongnu.org>; Wed, 23 Feb 2011 16:24:19 -0700
Message-ID: <4D65972C.1010505@linux.vnet.ibm.com>
Date: Wed, 23 Feb 2011 17:24:28 -0600
From: Anthony Liguori <aliguori@linux.vnet.ibm.com>
MIME-Version: 1.0
References: <1297885680-17860-1-git-send-email-weil@mail.berlios.de>
	<4D5C309C.8010701@linux.vnet.ibm.com>
	<4D6582CB.4050503@mail.berlios.de>
In-Reply-To: <4D6582CB.4050503@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] vnc: Fix fatal crash with vnc reverse mode
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: qemu-devel@nongnu.org

On 02/23/2011 03:57 PM, Stefan Weil wrote:
> Am 16.02.2011 21:16, schrieb Anthony Liguori:
>> On 02/16/2011 01:48 PM, Stefan Weil wrote:
>>> Reverse mode is unusable:
>>>
>>>     qemu -vnc localhost:5500,reverse
>>>
>>> crashes in vnc_refresh_server_surface because some pointers are NULL.
>>>
>>> Fix this by calling vnc_dpy_resize (which initializes these pointers)
>>> before calling vnc_refresh.
>>>
>>> Cc: Anthony Liguori<aliguori@us.ibm.com>
>>> Signed-off-by: Stefan Weil<weil@mail.berlios.de>
>>
>> Nice catch!
>>
>> Regards,
>>
>> Anthony Liguori
>
>
> What now? Will the patch be committed, is there a different fix for 
> this bug,
> or are you planning to remove vnc because it is unmaintained?

Cute.

Regards,

Anthony Liguori

>
> Stefan
>