From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=47070 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsW5S-0005Kg-CY
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 02:58:11 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PsW5Q-0006dR-Mx
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 02:58:09 -0500
Received: from mail-ew0-f45.google.com ([209.85.215.45]:60479)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1PsW5Q-0006d2-Ho
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 02:58:08 -0500
Received: by ewy24 with SMTP id 24so95189ewy.4
	for <qemu-devel@nongnu.org>; Wed, 23 Feb 2011 23:58:07 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <4D660F8C.3030406@redhat.com>
Date: Thu, 24 Feb 2011 08:58:04 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <cover.1298492768.git.quintela@redhat.com>	<8b675b6ffee29ec15f2b73a9fd47e334429f5c5c.1298492768.git.quintela@redhat.com>	<4D6587C7.6030604@codemonkey.ws>
	<m3mxlm2wtm.fsf@trasno.org>	<4D659295.1070400@codemonkey.ws>
	<m3k4gphps1.fsf@blackfin.pond.sub.org>
In-Reply-To: <m3k4gphps1.fsf@blackfin.pond.sub.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 16/28] migration: use global variable
	directly
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-devel@nongnu.org, quintela@redhat.com

On 02/24/2011 08:09 AM, Markus Armbruster wrote:
> For completeness: a local variable may be necessary to convince the
> optimizer that the value doesn't change.  Cases where this matters
> exist, but they're rare.

In particular, for non-pointers they're nonexistent if the variable is 
static and you never use &current_migration, i.e. if the variable 
doesn't escape.

If the above conditions are satisfied and you have a loop that never 
"leaves" the C file, you could even see the compiler keep the variable 
in a register for the whole duration of the loop and store the modified 
change after the loop.

Paolo