From: Yoshiaki Tamura <tamura.yoshiaki@lab.ntt.co.jp>
To: quintela@redhat.com
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: [PATCH 21/28] migration: Make state definitions local
Date: Thu, 24 Feb 2011 18:16:20 +0900 [thread overview]
Message-ID: <4D6621E4.8030601@lab.ntt.co.jp> (raw)
In-Reply-To: <m3lj156c1t.fsf@trasno.org>
Juan Quintela wrote:
> Yoshiaki Tamura<tamura.yoshiaki@lab.ntt.co.jp> wrote:
>> 2011/2/24 Juan Quintela<quintela@redhat.com>:
>>>
>>> Signed-off-by: Juan Quintela<quintela@redhat.com>
>>> ---
>>> migration.c | 8 ++++++++
>>> migration.h | 8 --------
>>> 2 files changed, 8 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/migration.c b/migration.c
>>> index 493c2d7..697c74f 100644
>>> --- a/migration.c
>>> +++ b/migration.c
>>> @@ -31,6 +31,14 @@
>>> do { } while (0)
>>> #endif
>>>
>>> +enum migration_state {
>>> + MIG_STATE_ERROR,
>>
>> Would be better to say:
>>
>> MIG_STATE_ERROR = -1,
>
> I thought about it, but basically it shouldn't matter, no?
It shouldn't. Just gives clear impression :)
Yoshi
>
> Later, Juan.
>
>
next prev parent reply other threads:[~2011-02-24 9:16 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-23 21:47 [Qemu-devel] [PATCH v2 00/28] Refactor and cleanup migration code Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 01/28] migration: Make *start_outgoing_migration return FdMigrationState Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 02/28] migration: Use FdMigrationState instead of MigrationState when possible Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 03/28] migration: Fold MigrationState into FdMigrationState Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 04/28] migration: Rename FdMigrationState MigrationState Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 05/28] migration: Refactor MigrationState creation Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 06/28] migration: Make all posible migration functions static Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 07/28] migration: move migrate_create_state to do_migrate Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 08/28] migration: Check that migration is active before cancel it Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 09/28] migration: Introduce MIG_STATE_NONE Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 10/28] migration: Refactor and simplify error checking in migrate_fd_put_ready Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 11/28] migration: Introduce migrate_fd_completed() for consistenncy Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 12/28] migration: Our release callback was just free Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 13/28] migration: Remove get_status() accessor Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 14/28] migration: Remove migration cancel() callback Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 15/28] migration: Move exported functions to the end of the file Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 16/28] migration: use global variable directly Juan Quintela
2011-02-23 22:18 ` Anthony Liguori
2011-02-23 22:46 ` [Qemu-devel] " Juan Quintela
2011-02-23 23:04 ` Anthony Liguori
2011-02-23 23:07 ` Juan Quintela
2011-02-24 7:09 ` Markus Armbruster
2011-02-24 7:58 ` Paolo Bonzini
2011-02-23 21:47 ` [Qemu-devel] [PATCH 17/28] migration: another case of global variable assigned to local one Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 18/28] migration: convert current_migration from pointer to struct Juan Quintela
2011-02-23 22:19 ` Anthony Liguori
2011-02-23 22:50 ` [Qemu-devel] " Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 19/28] migration: Use bandwidth_limit directly Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 20/28] migration: Export a function that tells if the migration has finished correctly Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 21/28] migration: Make state definitions local Juan Quintela
2011-02-24 4:12 ` Yoshiaki Tamura
2011-02-24 9:01 ` [Qemu-devel] " Juan Quintela
2011-02-24 9:16 ` Yoshiaki Tamura [this message]
2011-02-23 21:47 ` [Qemu-devel] [PATCH 22/28] savevm: avoid qemu_savevm_state_iteate() to return 1 when qemu file has error Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 23/28] migration: add error handling to migrate_fd_put_notify() Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 24/28] migration: Don't use callback on file defining it Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 25/28] migration: propagate error correctly Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 26/28] migration: qemu_savevm_iterate has three return values Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 27/28] migration: If there is one error, it makes no sense to continue Juan Quintela
2011-02-23 21:47 ` [Qemu-devel] [PATCH 28/28] migration: make migration-{tcp, unix} consistent Juan Quintela
2011-04-02 7:54 ` [Qemu-devel] [PATCH v2 00/28] Refactor and cleanup migration code Yoshiaki Tamura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4D6621E4.8030601@lab.ntt.co.jp \
--to=tamura.yoshiaki@lab.ntt.co.jp \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).