From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=46392 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsfVi-0008FK-NE
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 13:01:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PsfVF-0005q5-Uq
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 13:01:30 -0500
Received: from mail-vw0-f45.google.com ([209.85.212.45]:47331)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PsfVF-0005q1-R9
	for qemu-devel@nongnu.org; Thu, 24 Feb 2011 13:01:25 -0500
Received: by vws19 with SMTP id 19so718863vws.4
	for <qemu-devel@nongnu.org>; Thu, 24 Feb 2011 10:01:25 -0800 (PST)
Message-ID: <4D669C7D.8090209@codemonkey.ws>
Date: Thu, 24 Feb 2011 11:59:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Xen-devel] Re: [Qemu-devel] [PATCH V10 02/15] xen: Make xen
	build only on x86 target.
References: <1296658172-16609-1-git-send-email-anthony.perard@citrix.com>	<1296658172-16609-3-git-send-email-anthony.perard@citrix.com>	<4D668346.4010903@codemonkey.ws>	<AANLkTimEBMzMYvcdCbvi1QJFCU0fP346fWJsOvwuM4+6@mail.gmail.com>	<4D669507.3030509@codemonkey.ws>
	<4D669977.2010507@siemens.com>
In-Reply-To: <4D669977.2010507@siemens.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Anthony PERARD <anthony.perard@citrix.com>, Xen Devel <xen-devel@lists.xensource.com>, Alexander Graf <agraf@suse.de>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>, QEMU-devel <qemu-devel@nongnu.org>

On 02/24/2011 11:46 AM, Jan Kiszka wrote:
> On 2011-02-24 18:27, Anthony Liguori wrote:
>    
>> On 02/24/2011 10:25 AM, Anthony PERARD wrote:
>>      
>>> On Thu, Feb 24, 2011 at 16:11, Anthony Liguori<anthony@codemonkey.ws>   wrote:
>>>
>>>        
>>>> Is this really necessary?  The advantage to building globally is that it
>>>> keeps the code from getting unnecessary i386-isms.
>>>>
>>>>          
>>> Nop, is not necessary, I add this patch after this mail:
>>> http://lists.nongnu.org/archive/html/qemu-devel/2010-12/msg00044.html
>>>
>>>        
>> Alex, do you feel strongly here?
>>      
> I'm not Alex, but I brought this issue up:
>
> Either build xen bits once for all archs or restrict it to the only
> foreseeable arch with support in qemu. But please don't built it for
> each and every target separately.
>    

Oh yes, I misunderstood.  I thought we had previously built it for all 
architectures.  Yes, we should only build it once.

Regards,

Anthony Liguori

> BTW:
>
>    
>> index b0ba95f..db29e96 100644
>> --- a/Makefile.target
>> +++ b/Makefile.target
>> @@ -206,7 +206,9 @@ QEMU_CFLAGS += $(VNC_JPEG_CFLAGS)
>>   QEMU_CFLAGS += $(VNC_PNG_CFLAGS)
>>
>>   # xen backend driver support
>> -obj-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>> +obj-$(CONFIG_XEN) += xen_backend.o xen_devconfig.o
>> +obj-$(CONFIG_XEN) += xen_console.o xenfb.o xen_disk.o xen_nic.o
>> +obj-i386-$(CONFIG_XEN) += xen_machine_pv.o xen_domainbuild.o
>>      
> Why restricting the last line to i386? Doesn't CONFIG_XEN also control
> here if the arch is xen-capable?
>
> Thanks,
> Jan
>
>