qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore
@ 2011-02-24  5:34 David Gibson
  2011-02-24  7:05 ` Markus Armbruster
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: David Gibson @ 2011-02-24  5:34 UTC (permalink / raw)
  To: qemu-devel

Add the etags output generated by "make TAGS" and editor backup files
to .gitignore.

This patch has previously appeared in my series of patches to add
pSeries emulation support.  However, it obviously has no real
connection to that, and can be applied seperately.

Please apply.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 .gitignore |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/.gitignore b/.gitignore
index 26703e1..1d79680 100644
--- a/.gitignore
+++ b/.gitignore
@@ -63,3 +63,5 @@ pc-bios/optionrom/multiboot.raw
 .stgit-*
 cscope.*
 tags
+TAGS
+*~
-- 
1.7.1


-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore
  2011-02-24  5:34 [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore David Gibson
@ 2011-02-24  7:05 ` Markus Armbruster
  2011-02-24  9:19 ` [Qemu-devel] " Juan Quintela
  2011-02-24 18:10 ` [Qemu-devel] " Anthony Liguori
  2 siblings, 0 replies; 5+ messages in thread
From: Markus Armbruster @ 2011-02-24  7:05 UTC (permalink / raw)
  To: David Gibson; +Cc: qemu-devel

David Gibson <david@gibson.dropbear.id.au> writes:

> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.

Yes, please.

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [Qemu-devel] Re: [PATCH] Add TAGS and *~ to .gitignore
  2011-02-24  5:34 [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore David Gibson
  2011-02-24  7:05 ` Markus Armbruster
@ 2011-02-24  9:19 ` Juan Quintela
  2011-02-24 18:10 ` [Qemu-devel] " Anthony Liguori
  2 siblings, 0 replies; 5+ messages in thread
From: Juan Quintela @ 2011-02-24  9:19 UTC (permalink / raw)
  To: David Gibson; +Cc: qemu-devel

David Gibson <david@gibson.dropbear.id.au> wrote:
> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.
>
> Signed-off-by: David Gibson <david@gibson.dropbear.id.au>

Reviewed-by: Juan Quintela <quintela@redhat.com>

O:-)

> ---
>  .gitignore |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 26703e1..1d79680 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,5 @@ pc-bios/optionrom/multiboot.raw
>  .stgit-*
>  cscope.*
>  tags
> +TAGS
> +*~
> -- 
> 1.7.1

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore
  2011-02-24  5:34 [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore David Gibson
  2011-02-24  7:05 ` Markus Armbruster
  2011-02-24  9:19 ` [Qemu-devel] " Juan Quintela
@ 2011-02-24 18:10 ` Anthony Liguori
  2011-02-24 20:21   ` Future entries for .gitignore (was Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore) Stefan Weil
  2 siblings, 1 reply; 5+ messages in thread
From: Anthony Liguori @ 2011-02-24 18:10 UTC (permalink / raw)
  To: David Gibson; +Cc: qemu-devel

On 02/23/2011 11:34 PM, David Gibson wrote:
> Add the etags output generated by "make TAGS" and editor backup files
> to .gitignore.
>
> This patch has previously appeared in my series of patches to add
> pSeries emulation support.  However, it obviously has no real
> connection to that, and can be applied seperately.
>
> Please apply.
>
> Signed-off-by: David Gibson<david@gibson.dropbear.id.au>
>    

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   .gitignore |    2 ++
>   1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 26703e1..1d79680 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -63,3 +63,5 @@ pc-bios/optionrom/multiboot.raw
>   .stgit-*
>   cscope.*
>   tags
> +TAGS
> +*~
>    

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Future entries for .gitignore (was Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore)
  2011-02-24 18:10 ` [Qemu-devel] " Anthony Liguori
@ 2011-02-24 20:21   ` Stefan Weil
  0 siblings, 0 replies; 5+ messages in thread
From: Stefan Weil @ 2011-02-24 20:21 UTC (permalink / raw)
  To: qemu-devel

.gitignore contains two categories of entries:

(1) files and directories which are created during configure / make

(2) files which might be created by users, editors and other tools

The 1st category of files is needed by any developer who runs make
in the source tree. There was once a suggestion to remove support
for in-tree builds. Out-of-tree builds would not need any entry in
.gitignore. So maintenance could be made easier, although I
don't recommend this.

The 2nd category is virtually endless because there are so many
different editors, IDEs, debuggers and other tools which create
different files. The entries here are nothing which is typical
of qemu. These entries are typical for the user: Do I use ctags?
Does my editor write *.bak or *~ files? Do I want a .gdbinit? ...

Therefore I think that all entries of the 2nd category should be
configured by the user in his/her personal git ignore list
(see git config setting core.excludesfile).

Regards,
Stefan Weil

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2011-02-24 20:21 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-24  5:34 [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore David Gibson
2011-02-24  7:05 ` Markus Armbruster
2011-02-24  9:19 ` [Qemu-devel] " Juan Quintela
2011-02-24 18:10 ` [Qemu-devel] " Anthony Liguori
2011-02-24 20:21   ` Future entries for .gitignore (was Re: [Qemu-devel] [PATCH] Add TAGS and *~ to .gitignore) Stefan Weil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).