From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=54324 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PsmYl-0004N6-TU for qemu-devel@nongnu.org; Thu, 24 Feb 2011 20:33:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PsmYk-0003GE-Tr for qemu-devel@nongnu.org; Thu, 24 Feb 2011 20:33:31 -0500 Received: from [222.73.24.84] (port=63880 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PsmYk-0003FP-I0 for qemu-devel@nongnu.org; Thu, 24 Feb 2011 20:33:30 -0500 Message-ID: <4D670695.7040404@cn.fujitsu.com> Date: Fri, 25 Feb 2011 09:32:05 +0800 From: Wen Congyang MIME-Version: 1.0 Subject: Re: [Qemu-devel] null mac address References: In-Reply-To: Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: William Dauchy Cc: qemu-devel@nongnu.org At 02/24/2011 10:40 PM, William Dauchy Write: > Hi, > > I got some troubles hot plugging network pci devices. An attach works > as expected but the mac address is still set to "00:00:00:00:00:00" on > the guest machine. I have to reboot the guest to get the correct mac > address. > I first tried through libvirt with: > # virsh attach-interface dom0 network default --mac 52:54:00:f6:84:ba > > and then through qemu monitor to make sure that it wasn't a libvirt issue: > device_add rtl8139 > or > device_add rtl8139,mac=01:02:03:04:05:06 > > Always the same result on the guest. A device info on qemu give the > correct result, that is to say, with a correct mac address. > I went through rtl8139.c and saw that the mac address is set in `rtl8139_reset`. > This function was called in `pci_rtl8139_init` but removed since > c169998802505c244b8bcad562633f29de7d74a4 commit, because it doesn't > make sense to call it when the virtual machine is shutdown. > I'm now wondering where I am supposed to call this reset function when > live attaching a pci device. I think it could fix the mac address > issue. > I will be very pleased to receive some tips to create a patch for this issue. I got the same troubles, but I don't notice commit c1699988, and I sent a patch(call reset function in init) some days before. So I think this patch is wrong. I think the following method can solve this problem: move eeprom init from reset function into init function, as it is read only, and does not need init again in reset function. I will test this method. If it's OK, I will send a new patch. Thnaks Wen Congyang > > Regards,