From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36458 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PsyQk-0001CW-75
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:14:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PsyQj-0003Dg-3Y
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:14:02 -0500
Received: from mail-vw0-f45.google.com ([209.85.212.45]:63271)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PsyQi-0003Dc-Vy
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 09:14:01 -0500
Received: by vws19 with SMTP id 19so1533951vws.4
	for <qemu-devel@nongnu.org>; Fri, 25 Feb 2011 06:14:00 -0800 (PST)
Message-ID: <4D67B81D.8000600@codemonkey.ws>
Date: Fri, 25 Feb 2011 08:09:33 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH V10 05/15] xen: Add xenfv machine
References: <1296658172-16609-1-git-send-email-anthony.perard@citrix.com>	<1296658172-16609-6-git-send-email-anthony.perard@citrix.com>	<4D6695E6.7040004@codemonkey.ws>
	<AANLkTimdku9oDbSoE0iw-DYUmL7Y7x1uZqtBcLxN+Sgg@mail.gmail.com>
In-Reply-To: <AANLkTimdku9oDbSoE0iw-DYUmL7Y7x1uZqtBcLxN+Sgg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony PERARD <anthony.perard@citrix.com>
Cc: Xen Devel <xen-devel@lists.xensource.com>, QEMU-devel <qemu-devel@nongnu.org>, Stefano Stabellini <stefano.stabellini@eu.citrix.com>

On 02/25/2011 07:55 AM, Anthony PERARD wrote:
> On Thu, Feb 24, 2011 at 17:31, Anthony Liguori<anthony@codemonkey.ws>  wrote:
>    
>>> diff --git a/hw/pc_piix.c b/hw/pc_piix.c
>>> index 7b74473..0ab8907 100644
>>> --- a/hw/pc_piix.c
>>> +++ b/hw/pc_piix.c
>>> @@ -36,6 +36,10 @@
>>>   #include "sysbus.h"
>>>   #include "arch_init.h"
>>>   #include "blockdev.h"
>>> +#include "xen.h"
>>> +#ifdef CONFIG_XEN
>>> +#  include "xen/hvm/hvm_info_table.h"
>>> +#endif
>>>
>>>        
>> Admittedly a nit, but isn't this a system header?
>>      
> It belongs to Xen. I use it for HVM_MAX_VCPUS.
>
> I can put it in xen.h, if you prefer.
>    

I meant, you should use:

#include <xen/hvm/hvm_info_table.h>

Regards,

Anthony Liguori

> Regards,
>
>