From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=45515 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pt5qB-00023l-Qu for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:08:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt5q5-0007dJ-Vz for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:08:47 -0500 Received: from mail-vw0-f45.google.com ([209.85.212.45]:39804) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt5q5-0007d1-Tc for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:08:41 -0500 Received: by vws19 with SMTP id 19so1963023vws.4 for ; Fri, 25 Feb 2011 14:08:41 -0800 (PST) Message-ID: <4D682866.9070005@codemonkey.ws> Date: Fri, 25 Feb 2011 16:08:38 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Outdated comment in HACKING References: In-Reply-To: Content-Type: multipart/alternative; boundary="------------000201010601070607030705" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------000201010601070607030705 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit This patch won't apply with git-am because your mailer is doing weird things. Please use git-send-email to send the patch. Regards, Anthony Liguori On 02/24/2011 06:27 PM, Joey Trebbien wrote: > All printf-style functions in the source (except for a few in tests/) > already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR > macros). > > Signed-off-by: Joseph Trebbien > > --- > HACKING | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > > diff --git a/HACKING b/HACKING > index 6ba9d7e..3af53fd 100644 > --- a/HACKING > +++ b/HACKING > @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. > This makes it so gcc's -Wformat and -Wformat-security options can do > their jobs and cross-check format strings with the number and types > of arguments. > - > -Currently many functions in QEMU are not following this rule but > -patches to add the attribute would be very much appreciated. --------------000201010601070607030705 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit This patch won't apply with git-am because your mailer is doing weird things. Please use git-send-email to send the patch.

Regards,

Anthony Liguori

On 02/24/2011 06:27 PM, Joey Trebbien wrote:

All printf-style functions in the source (except for a few in tests/) already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR macros).

Signed-off-by: Joseph Trebbien <jtrebbien@gmail.com>

---

HACKING | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/HACKING b/HACKING
index 6ba9d7e..3af53fd 100644
--- a/HACKING
+++ b/HACKING
@@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.
-
-Currently many functions in QEMU are not following this rule but
-patches to add the attribute would be very much appreciated.

--------------000201010601070607030705--