* [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format checking
@ 2011-02-25 22:20 Stefan Weil
2011-02-25 22:50 ` Anthony Liguori
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2011-02-25 22:20 UTC (permalink / raw)
To: Blue Swirl; +Cc: Anthony Liguori, QEMU Developers
This patch was already sent on 2011-01-24:
Hopefully all functions with printf like arguments now use format checking.
This was tested with default build configuration on linux
and windows hosts (including some cross compilations),
so chances are good that there remain few (if any) functions
without format checking.
Therefore the last comment in HACKING is no longer valid but misleading.
Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Weil <weil@mail.berlios.de>
---
HACKING | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/HACKING b/HACKING
index 6ba9d7e..3af53fd 100644
--- a/HACKING
+++ b/HACKING
@@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.
-
-Currently many functions in QEMU are not following this rule but
-patches to add the attribute would be very much appreciated.
--
1.7.2.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format checking
2011-02-25 22:20 [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format checking Stefan Weil
@ 2011-02-25 22:50 ` Anthony Liguori
0 siblings, 0 replies; 2+ messages in thread
From: Anthony Liguori @ 2011-02-25 22:50 UTC (permalink / raw)
To: Stefan Weil; +Cc: Blue Swirl, Anthony Liguori, QEMU Developers
On 02/25/2011 04:20 PM, Stefan Weil wrote:
> This patch was already sent on 2011-01-24:
>
> Hopefully all functions with printf like arguments now use format
> checking.
>
> This was tested with default build configuration on linux
> and windows hosts (including some cross compilations),
> so chances are good that there remain few (if any) functions
> without format checking.
>
> Therefore the last comment in HACKING is no longer valid but misleading.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
> HACKING | 3 ---
> 1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/HACKING b/HACKING
> index 6ba9d7e..3af53fd 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
> This makes it so gcc's -Wformat and -Wformat-security options can do
> their jobs and cross-check format strings with the number and types
> of arguments.
> -
> -Currently many functions in QEMU are not following this rule but
> -patches to add the attribute would be very much appreciated.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-02-25 22:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-25 22:20 [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format checking Stefan Weil
2011-02-25 22:50 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).