From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=37508 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pt61Y-0006Dt-66 for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:20:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt61X-0000pJ-24 for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:20:32 -0500 Received: from moutng.kundenserver.de ([212.227.126.171]:60695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt61W-0000oe-NV for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:20:31 -0500 Message-ID: <4D682B29.5070001@mail.berlios.de> Date: Fri, 25 Feb 2011 23:20:25 +0100 From: Stefan Weil MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format checking List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Anthony Liguori , QEMU Developers This patch was already sent on 2011-01-24: Hopefully all functions with printf like arguments now use format checking. This was tested with default build configuration on linux and windows hosts (including some cross compilations), so chances are good that there remain few (if any) functions without format checking. Therefore the last comment in HACKING is no longer valid but misleading. Cc: Blue Swirl Signed-off-by: Stefan Weil --- HACKING | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/HACKING b/HACKING index 6ba9d7e..3af53fd 100644 --- a/HACKING +++ b/HACKING @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. This makes it so gcc's -Wformat and -Wformat-security options can do their jobs and cross-check format strings with the number and types of arguments. - -Currently many functions in QEMU are not following this rule but -patches to add the attribute would be very much appreciated. -- 1.7.2.3