From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=40956 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pt62O-0006nO-6N for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:21:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pt62M-0000tw-CA for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:21:23 -0500 Received: from moutng.kundenserver.de ([212.227.17.10]:49298) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pt62L-0000tg-Sn for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:21:22 -0500 Message-ID: <4D682B5E.3080201@mail.berlios.de> Date: Fri, 25 Feb 2011 23:21:18 +0100 From: Stefan Weil MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Outdated comment in HACKING References: <4D682866.9070005@codemonkey.ws> In-Reply-To: <4D682866.9070005@codemonkey.ws> Content-Type: multipart/alternative; boundary="------------050508070103070502070407" List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Joseph Trebbien , qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------050508070103070502070407 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Am 25.02.2011 23:08, schrieb Anthony Liguori: > This patch won't apply with git-am because your mailer is doing weird > things. Please use git-send-email to send the patch. > > Regards, > > Anthony Liguori > > On 02/24/2011 06:27 PM, Joey Trebbien wrote: >> All printf-style functions in the source (except for a few in tests/) >> already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR >> macros). >> >> Signed-off-by: Joseph Trebbien > > >> --- >> HACKING | 3 --- >> 1 files changed, 0 insertions(+), 3 deletions(-) >> >> >> diff --git a/HACKING b/HACKING >> index 6ba9d7e..3af53fd 100644 >> --- a/HACKING >> +++ b/HACKING >> @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype. >> This makes it so gcc's -Wformat and -Wformat-security options can do >> their jobs and cross-check format strings with the number and types >> of arguments. >> - >> -Currently many functions in QEMU are not following this rule but >> -patches to add the attribute would be very much appreciated. > Hi Anthony, the same patch is on my list of missing patches which I had sent weeks ago, so no need for Joey to resent his patch. I'll resend my version. Regards, Stefan W. --------------050508070103070502070407 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Am 25.02.2011 23:08, schrieb Anthony Liguori:
This patch won't apply with git-am because your mailer is doing weird things.  Please use git-send-email to send the patch.

Regards,

Anthony Liguori

On 02/24/2011 06:27 PM, Joey Trebbien wrote:
All printf-style functions in the source (except for a few in tests/) already have a format __attribute__ (via the GCC_ATTR or GCC_FMT_ATTR macros).

Signed-off-by:  Joseph Trebbien <jtrebbien@gmail.com>
---
HACKING | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)


diff --git a/HACKING b/HACKING
index 6ba9d7e..3af53fd 100644
--- a/HACKING
+++ b/HACKING
@@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
This makes it so gcc's -Wformat and -Wformat-security options can do
their jobs and cross-check format strings with the number and types
of arguments.
-
-Currently many functions in QEMU are not following this rule but
-patches to add the attribute would be very much appreciated.



Hi Anthony,

the same patch is on my list of missing patches which I had sent
weeks ago, so no need for Joey to resent his patch.

I'll resend my version.

Regards,
Stefan W.

--------------050508070103070502070407--