From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=49832 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Pt6Ue-0007Hs-S4
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:50:52 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pt6UT-0005eg-Lk
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:50:35 -0500
Received: from mail-vw0-f45.google.com ([209.85.212.45]:45492)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1Pt6UT-0005eL-JJ
	for qemu-devel@nongnu.org; Fri, 25 Feb 2011 17:50:25 -0500
Received: by vws19 with SMTP id 19so1991869vws.4
	for <qemu-devel@nongnu.org>; Fri, 25 Feb 2011 14:50:24 -0800 (PST)
Message-ID: <4D68322D.9030309@codemonkey.ws>
Date: Fri, 25 Feb 2011 16:50:21 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RESENT][PATCH] HACKING: Update status of format
	checking
References: <4D682B29.5070001@mail.berlios.de>
In-Reply-To: <4D682B29.5070001@mail.berlios.de>
Content-Type: text/plain; charset=ISO-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Weil <weil@mail.berlios.de>
Cc: Blue Swirl <blauwirbel@gmail.com>, Anthony Liguori <aliguori@us.ibm.com>, QEMU Developers <qemu-devel@nongnu.org>

On 02/25/2011 04:20 PM, Stefan Weil wrote:
> This patch was already sent on 2011-01-24:
>
> Hopefully all functions with printf like arguments now use format 
> checking.
>
> This was tested with default build configuration on linux
> and windows hosts (including some cross compilations),
> so chances are good that there remain few (if any) functions
> without format checking.
>
> Therefore the last comment in HACKING is no longer valid but misleading.
>
> Cc: Blue Swirl <blauwirbel@gmail.com>
> Signed-off-by: Stefan Weil <weil@mail.berlios.de>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>  HACKING |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/HACKING b/HACKING
> index 6ba9d7e..3af53fd 100644
> --- a/HACKING
> +++ b/HACKING
> @@ -120,6 +120,3 @@ gcc's printf attribute directive in the prototype.
>  This makes it so gcc's -Wformat and -Wformat-security options can do
>  their jobs and cross-check format strings with the number and types
>  of arguments.
> -
> -Currently many functions in QEMU are not following this rule but
> -patches to add the attribute would be very much appreciated.