From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=36807 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PtM8l-0000Mc-9a
	for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:33:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PtM8d-0005rW-Ot
	for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:33:03 -0500
Received: from mail-yx0-f173.google.com ([209.85.213.173]:47044)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1PtM8d-0005rG-L0
	for qemu-devel@nongnu.org; Sat, 26 Feb 2011 10:32:55 -0500
Received: by yxk8 with SMTP id 8so1296432yxk.4
	for <qemu-devel@nongnu.org>; Sat, 26 Feb 2011 07:32:54 -0800 (PST)
Message-ID: <4D691D24.7080709@codemonkey.ws>
Date: Sat, 26 Feb 2011 09:32:52 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [patch 2/3] Add support for live block copy
References: <20110222170004.808373778@redhat.com>	<20110222170115.710717278@redhat.com>	<4D655AC6.3090503@codemonkey.ws>
	<20110226000214.GA30160@amt.cnet>
In-Reply-To: <20110226000214.GA30160@amt.cnet>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Marcelo Tosatti <mtosatti@redhat.com>
Cc: Jes.Sorensen@redhat.com, qemu-devel@nongnu.org, avi@redhat.com

On 02/25/2011 06:02 PM, Marcelo Tosatti wrote:
>>> +- "commit_filename": target commit filename (json-string, optional)
>>>        
>> I think we should drop this.
>>      
> Why? Sorry but this can't wait for non-config persistent storage. This
> mistake was made in the past with irqchip for example, lets not repeat
> it.
>
> Its OK to deprecate "commit_filename" in favour of its location in
> non-config persistent storage.
>
> Its not the end of the world for a mgmt app to handle change (not saying
> its not a good principle) such as this

If you're looking for a stop-gap, I'd suggest adding an optional 
"action" parameter.  This parameter would take a string with valid 
values of "stop", "none".

If action=stop, then when block copy finishes, the guest will be stopped 
and an event will be sent.  This lets a management tool get notified, 
update it's config, and then continue the guest.  If the management tool 
crashes, it can do a query-block-copy to see that the copy finished 
along with a query-status to fix the guest.

This is more in line with how our other commands work.

Regards,

Anthony Liguori