From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=57958 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PtdDh-0004tp-MD for qemu-devel@nongnu.org; Sun, 27 Feb 2011 04:47:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PtdDg-0005Ff-KC for qemu-devel@nongnu.org; Sun, 27 Feb 2011 04:47:17 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:57529) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PtdDf-0005Fa-SO for qemu-devel@nongnu.org; Sun, 27 Feb 2011 04:47:16 -0500 Message-ID: <4D6A1DA2.7030502@web.de> Date: Sun, 27 Feb 2011 10:47:14 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1298734819-1960-1-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig23E448FA6A32B5327986CB05" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [PATCH v2 uq/master 00/22] Win32 iothread support List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: qemu-devel@nongnu.org, aurelien@aurel32.net This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig23E448FA6A32B5327986CB05 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable On 2011-02-26 16:39, Paolo Bonzini wrote: > After gathering the comments about the two series I sent separately, > here is the full series for Win32 iothread support, ready to be > applied to uq/master. >=20 > Patches 1 to 5 are generic Win32 improvements, including the qemu-threa= d > implementation. Because of complex dependencies, I think it's better > if this part is also routed through uq/master. Agreed. This also ensures that the non-Win32 parts receive autotest blessing before being applied. >=20 > Patches 6 to 8 are generic threading improvements, including using > PTHREAD_MUTEX_ERRORCHECK as suggested by Jan. >=20 > Patches 9 to 17 eliminate polling, replacing condition variable > timedwait with wait. >=20 > Patch 18 removes a redundant condition from the TCG cpu_exec_all > function. >=20 > Patches 19 to 21 add all necessary stubs to make iothread compile > with Win32, except the IPI calls. These are provided by patch 22. >=20 > Tested on Wine and Linux, not on "real" Windows. The series introduces= > a dependency on Windows 2K or newer. I don't think either 95/98/ME > or Windows NT 3.x are reasonable host systems for QEMU, anyway. >=20 > I incorporated all suggestions from Jan, including his renaming patch > for qemu_*_is_self, and included Aurelien's sh4 tweak to cpu_halted. >=20 #ifndef _WIN32 Except for the minor remarks, looks very good to me. #else Can't asses. #endif Jan --------------enig23E448FA6A32B5327986CB05 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.15 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org/ iEYEARECAAYFAk1qHaIACgkQitSsb3rl5xSDFQCfbIl8QIhteyFeS2d0Au+yNpCC 2KwAoI/6ZXcu27X1FvqO3Eqpic13v8EA =QqAW -----END PGP SIGNATURE----- --------------enig23E448FA6A32B5327986CB05--